Date: Fri, 9 Aug 2013 21:11:25 +0200 (CEST) From: Christoph Moench-Tegeder <cmt@burggraben.net> To: FreeBSD-gnats-submit@freebsd.org Subject: ports/181169: www/firefox build fails with webrtc and pulseaudio Message-ID: <20130809191125.BBC3030AF6@elch.exwg.net> Resent-Message-ID: <201308091920.r79JK1uE063514@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 181169
>Category: ports
>Synopsis: www/firefox build fails with webrtc and pulseaudio
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Fri Aug 09 19:20:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator: Christoph Moench-Tegeder
>Release: FreeBSD 9.2-RC1 amd64
>Organization:
>Environment:
System: FreeBSD elch.exwg.net 9.2-RC1 FreeBSD 9.2-RC1 #7 r253915: Sun Aug 4 14:43:05 CEST 2013 cmt@elch.exwg.net:/usr/obj/usr/src/sys/ELCH amd64
www/firefox firefox-23.0,1
cmt@elch:firefox$ make showconfig
===> The following configuration options are available for firefox-23.0,1:
DBUS=on: D-Bus IPC system support
DEBUG=off: Install debug symbols
GCONF=on: GConf configuration backend support
GIO=on: GIO for file I/O
GNOMEUI=on: libgnomeui support module
GNOMEVFS2=on: GnomeVFS2 (virtual file system) support
GSTREAMER=on: Multimedia support via GStreamer
LIBPROXY=on: Proxy support via libproxy
LOGGING=off: Additional log messages
OPTIMIZED_CFLAGS=on: Use extra compiler optimizations
PGO=off: Use Profile-Guided Optimization
WEBRTC=on: Web Real-Time Communication
====> Options available for the single AUDIO: you have to select exactly one of them
ALSA=off: ALSA audio architecture support
PULSEAUDIO=on: PulseAudio sound server support
===> Use 'make config' to modify these settings
>Description:
build fails, error message (requires some digging):
/usr/ports/www/firefox/work/mozilla-release/media/webrtc/trunk/webrtc/modules/audio_device/linux/audio_device_pulse_linux.cc:82:5: error: initializer 'sample_rate_hz_' does not name a non-static data member or base class; did you mean the member 'sampling_rate_hz'?
sample_rate_hz_(0),
^~~~~~~~~~~~~~~
sampling_rate_hz
/usr/ports/www/firefox/work/mozilla-release/media/webrtc/trunk/webrtc/modules/audio_device/linux/audio_device_pulse_linux.h:313:19: note: 'sampling_rate_hz' declared here
WebRtc_Word32 sampling_rate_hz;
^
>How-To-Repeat:
use config as above (webrtc + pulseaudio)
this looks like a merging error at mozilla.
>Fix:
use the attached patch as /usr/ports/www/firefox/files/patch-media-webrtc-trunk-webrtc-modules-audio_device-linux-audio_device_pulse_linux.h .
I reported this issue upstream at
https://bugzilla.mozilla.org/show_bug.cgi?id=903549
Patch:
--- media/webrtc/trunk/webrtc/modules/audio_device/linux/audio_device_pulse_linux.h.orig 2013-08-09 20:23:23.000000000 +0200
+++ media/webrtc/trunk/webrtc/modules/audio_device/linux/audio_device_pulse_linux.h 2013-08-09 20:23:47.000000000 +0200
@@ -310,7 +310,7 @@
bool _inputDeviceIsSpecified;
bool _outputDeviceIsSpecified;
- WebRtc_Word32 sampling_rate_hz;
+ WebRtc_Word32 sample_rate_hz_;
WebRtc_UWord8 _recChannels;
WebRtc_UWord8 _playChannels;
Regards,
Christoph
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130809191125.BBC3030AF6>