Date: Fri, 13 Dec 2002 20:21:48 -0800 (PST) From: Kelly Yancey <kbyanc@posi.net> To: net@FreeBSD.org Subject: Re: Raw sockets and splnet() Message-ID: <20021213201926.A33726-200000@gateway.posi.net> In-Reply-To: <20021213194809.N33726-100000@gateway.posi.net>
next in thread | previous in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text,
while the remaining parts are likely unreadable without MIME-aware tools.
Send mail to mime@docserver.cac.washington.edu for more info.
--0-553016530-1039839708=:33726
Content-Type: TEXT/PLAIN; charset=US-ASCII
On Fri, 13 Dec 2002, Kelly Yancey wrote:
> Actually, as a follow-up to my own question, I don't see how the
> splnet()/splx() calls in rtsock.c are necessary at all as all of the pru_*
> hooks are called at splnet(). Being that rtsock's pru_* hooks are called at
> splnet(), is there any reason not to just extern the various raw_* pru hooks
> and reference them directly from route_usrreqs?
>
> Kelly
For a better idea of what I am talking about, a diff against 4.7 is
attached. I've confirmed that it compiles and will leave a machine running
with this patch up over the weekend. Any comments would be appreciated,
Kelly
--
Kelly Yancey -- kbyanc@{posi.net,FreeBSD.org}
FreeBSD, The Power To Serve: http://www.freebsd.org/
--0-553016530-1039839708=:33726
Content-Type: TEXT/PLAIN; charset=US-ASCII; name="rtsock.diff"
Content-Transfer-Encoding: BASE64
Content-ID: <20021213202148.A33726@gateway.posi.net>
Content-Description:
Content-Disposition: attachment; filename="rtsock.diff"
SW5kZXg6IHJhd19jYi5oDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1Mg
ZmlsZTogL2hvbWUvY3ZzL2Fjcy9iYXNlL3NyYy9zeXMvbmV0L3Jhd19jYi5o
LHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS4xLjEuMQ0KZGlmZiAtdSAtcCAt
cjEuMS4xLjEgcmF3X2NiLmgNCi0tLSByYXdfY2IuaAkyMiBNYXIgMjAwMiAw
NDoxMTowMCAtMDAwMAkxLjEuMS4xDQorKysgcmF3X2NiLmgJMTQgRGVjIDIw
MDIgMDQ6MTc6NTUgLTAwMDANCkBAIC03MSw2ICs3MSwxOSBAQCB2b2lkCSBy
YXdfaW5wdXQgX19QKChzdHJ1Y3QgbWJ1ZiAqLA0KIAkgICAgc3RydWN0IHNv
Y2twcm90byAqLCBzdHJ1Y3Qgc29ja2FkZHIgKiwgc3RydWN0IHNvY2thZGRy
ICopKTsNCiANCiBleHRlcm4Jc3RydWN0IHByX3VzcnJlcXMgcmF3X3VzcnJl
cXM7DQorDQoraW50CSByYXdfdWFib3J0IF9fUCgoc3RydWN0IHNvY2tldCAq
KSk7DQoraW50CSByYXdfdWF0dGFjaCBfX1AoKHN0cnVjdCBzb2NrZXQgKiwg
aW50LCBzdHJ1Y3QgcHJvYyAqKSk7DQoraW50CSByYXdfdWJpbmQgX19QKChz
dHJ1Y3Qgc29ja2V0ICosIHN0cnVjdCBzb2NrYWRkciAqLCBzdHJ1Y3QgcHJv
YyAqKSk7DQoraW50CSByYXdfdWNvbm5lY3QgX19QKChzdHJ1Y3Qgc29ja2V0
ICosIHN0cnVjdCBzb2NrYWRkciAqLCBzdHJ1Y3QgcHJvYyAqKSk7DQoraW50
CSByYXdfdWRldGFjaCBfX1AoKHN0cnVjdCBzb2NrZXQgKikpOw0KK2ludAkg
cmF3X3VkaXNjb25uZWN0IF9fUCgoc3RydWN0IHNvY2tldCAqKSk7DQoraW50
CSByYXdfdXBlZXJhZGRyIF9fUCgoc3RydWN0IHNvY2tldCAqLCBzdHJ1Y3Qg
c29ja2FkZHIgKiopKTsNCitpbnQJIHJhd191c2VuZCBfX1AoKHN0cnVjdCBz
b2NrZXQgKiwgaW50LCBzdHJ1Y3QgbWJ1ZiAqLCBzdHJ1Y3Qgc29ja2FkZHIg
KiwNCisJCQlzdHJ1Y3QgbWJ1ZiAqLCBzdHJ1Y3QgcHJvYyAqKSk7DQoraW50
CSByYXdfdXNodXRkb3duIF9fUCgoc3RydWN0IHNvY2tldCAqKSk7DQoraW50
CSByYXdfdXNvY2thZGRyIF9fUCgoc3RydWN0IHNvY2tldCAqLCBzdHJ1Y3Qg
c29ja2FkZHIgKiopKTsNCisNCiAjZW5kaWYNCiANCiAjZW5kaWYNCkluZGV4
OiByYXdfdXNycmVxLmMNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJDUyBm
aWxlOiAvaG9tZS9jdnMvYWNzL2Jhc2Uvc3JjL3N5cy9uZXQvcmF3X3VzcnJl
cS5jLHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS4xLjEuMQ0KZGlmZiAtdSAt
cCAtcjEuMS4xLjEgcmF3X3VzcnJlcS5jDQotLS0gcmF3X3VzcnJlcS5jCTIy
IE1hciAyMDAyIDA0OjExOjAwIC0wMDAwCTEuMS4xLjENCisrKyByYXdfdXNy
cmVxLmMJMTQgRGVjIDIwMDIgMDQ6MTc6NTUgLTAwMDANCkBAIC0xMzUsNyAr
MTM1LDcgQEAgcmF3X2N0bGlucHV0KGNtZCwgYXJnLCBkdW1teSkNCiAJLyog
SU5DT01QTEVURSAqLw0KIH0NCiANCi1zdGF0aWMgaW50DQoraW50DQogcmF3
X3VhYm9ydChzdHJ1Y3Qgc29ja2V0ICpzbykNCiB7DQogCXN0cnVjdCByYXdj
YiAqcnAgPSBzb3RvcmF3Y2Ioc28pOw0KQEAgLTE1MCw3ICsxNTAsNyBAQCBy
YXdfdWFib3J0KHN0cnVjdCBzb2NrZXQgKnNvKQ0KIA0KIC8qIHBydV9hY2Nl
cHQgaXMgRU9QTk9UU1VQUCAqLw0KIA0KLXN0YXRpYyBpbnQNCitpbnQNCiBy
YXdfdWF0dGFjaChzdHJ1Y3Qgc29ja2V0ICpzbywgaW50IHByb3RvLCBzdHJ1
Y3QgcHJvYyAqcCkNCiB7DQogCXN0cnVjdCByYXdjYiAqcnAgPSBzb3RvcmF3
Y2Ioc28pOw0KQEAgLTE2MywxMyArMTYzLDEzIEBAIHJhd191YXR0YWNoKHN0
cnVjdCBzb2NrZXQgKnNvLCBpbnQgcHJvdG8NCiAJcmV0dXJuIHJhd19hdHRh
Y2goc28sIHByb3RvKTsNCiB9DQogDQotc3RhdGljIGludA0KK2ludA0KIHJh
d191YmluZChzdHJ1Y3Qgc29ja2V0ICpzbywgc3RydWN0IHNvY2thZGRyICpu
YW0sIHN0cnVjdCBwcm9jICpwKQ0KIHsNCiAJcmV0dXJuIEVJTlZBTDsNCiB9
DQogDQotc3RhdGljIGludA0KK2ludA0KIHJhd191Y29ubmVjdChzdHJ1Y3Qg
c29ja2V0ICpzbywgc3RydWN0IHNvY2thZGRyICpuYW0sIHN0cnVjdCBwcm9j
ICpwKQ0KIHsNCiAJcmV0dXJuIEVJTlZBTDsNCkBAIC0xNzgsNyArMTc4LDcg
QEAgcmF3X3Vjb25uZWN0KHN0cnVjdCBzb2NrZXQgKnNvLCBzdHJ1Y3Qgcw0K
IC8qIHBydV9jb25uZWN0MiBpcyBFT1BOT1RTVVBQICovDQogLyogcHJ1X2Nv
bnRyb2wgaXMgRU9QTk9UU1VQUCAqLw0KIA0KLXN0YXRpYyBpbnQNCitpbnQN
CiByYXdfdWRldGFjaChzdHJ1Y3Qgc29ja2V0ICpzbykNCiB7DQogCXN0cnVj
dCByYXdjYiAqcnAgPSBzb3RvcmF3Y2Ioc28pOw0KQEAgLTE5MCw3ICsxOTAs
NyBAQCByYXdfdWRldGFjaChzdHJ1Y3Qgc29ja2V0ICpzbykNCiAJcmV0dXJu
IDA7DQogfQ0KIA0KLXN0YXRpYyBpbnQNCitpbnQNCiByYXdfdWRpc2Nvbm5l
Y3Qoc3RydWN0IHNvY2tldCAqc28pDQogew0KIAlzdHJ1Y3QgcmF3Y2IgKnJw
ID0gc290b3Jhd2NiKHNvKTsNCkBAIC0yMDcsNyArMjA3LDcgQEAgcmF3X3Vk
aXNjb25uZWN0KHN0cnVjdCBzb2NrZXQgKnNvKQ0KIA0KIC8qIHBydV9saXN0
ZW4gaXMgRU9QTk9UU1VQUCAqLw0KIA0KLXN0YXRpYyBpbnQNCitpbnQNCiBy
YXdfdXBlZXJhZGRyKHN0cnVjdCBzb2NrZXQgKnNvLCBzdHJ1Y3Qgc29ja2Fk
ZHIgKipuYW0pDQogew0KIAlzdHJ1Y3QgcmF3Y2IgKnJwID0gc290b3Jhd2Ni
KHNvKTsNCkBAIC0yMjQsNyArMjI0LDcgQEAgcmF3X3VwZWVyYWRkcihzdHJ1
Y3Qgc29ja2V0ICpzbywgc3RydWN0IA0KIC8qIHBydV9yY3ZkIGlzIEVPUE5P
VFNVUFAgKi8NCiAvKiBwcnVfcmN2b29iIGlzIEVPUE5PVFNVUFAgKi8NCiAN
Ci1zdGF0aWMgaW50DQoraW50DQogcmF3X3VzZW5kKHN0cnVjdCBzb2NrZXQg
KnNvLCBpbnQgZmxhZ3MsIHN0cnVjdCBtYnVmICptLA0KIAkgIHN0cnVjdCBz
b2NrYWRkciAqbmFtLCBzdHJ1Y3QgbWJ1ZiAqY29udHJvbCwgc3RydWN0IHBy
b2MgKnApDQogew0KQEAgLTI2Nyw3ICsyNjcsNyBAQCByZWxlYXNlOg0KIA0K
IC8qIHBydV9zZW5zZSBpcyBudWxsICovDQogDQotc3RhdGljIGludA0KK2lu
dA0KIHJhd191c2h1dGRvd24oc3RydWN0IHNvY2tldCAqc28pDQogew0KIAlz
dHJ1Y3QgcmF3Y2IgKnJwID0gc290b3Jhd2NiKHNvKTsNCkBAIC0yNzgsNyAr
Mjc4LDcgQEAgcmF3X3VzaHV0ZG93bihzdHJ1Y3Qgc29ja2V0ICpzbykNCiAJ
cmV0dXJuIDA7DQogfQ0KIA0KLXN0YXRpYyBpbnQNCitpbnQNCiByYXdfdXNv
Y2thZGRyKHN0cnVjdCBzb2NrZXQgKnNvLCBzdHJ1Y3Qgc29ja2FkZHIgKipu
YW0pDQogew0KIAlzdHJ1Y3QgcmF3Y2IgKnJwID0gc290b3Jhd2NiKHNvKTsN
CkluZGV4OiBydHNvY2suYw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNT
IGZpbGU6IC9ob21lL2N2cy9hY3MvYmFzZS9zcmMvc3lzL25ldC9ydHNvY2su
Yyx2DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMS4xLjINCmRpZmYgLXUgLXAg
LXIxLjEuMS4yIHJ0c29jay5jDQotLS0gcnRzb2NrLmMJMjMgQXVnIDIwMDIg
MDQ6MTA6MjcgLTAwMDAJMS4xLjEuMg0KKysrIHJ0c29jay5jCTE0IERlYyAy
MDAyIDA0OjE3OjU1IC0wMDAwDQpAQCAtODgsMTUgKzg4LDYgQEAgc3RhdGlj
IHZvaWQJIHJ0X3NldG1ldHJpY3MgX19QKCh1X2xvbmcsIA0KICAqIEl0IHJl
YWxseSBkb2Vzbid0IG1ha2UgYW55IHNlbnNlIGF0IGFsbCBmb3IgdGhpcyBj
b2RlIHRvIHNoYXJlIG11Y2gNCiAgKiB3aXRoIHJhd191c3JyZXEuYywgc2lu
Y2UgaXRzIGZ1bmN0aW9uYWxpdHkgaXMgc28gcmVzdHJpY3RlZC4gIFhYWA0K
ICAqLw0KLXN0YXRpYyBpbnQNCi1ydHNfYWJvcnQoc3RydWN0IHNvY2tldCAq
c28pDQotew0KLQlpbnQgcywgZXJyb3I7DQotCXMgPSBzcGxuZXQoKTsNCi0J
ZXJyb3IgPSByYXdfdXNycmVxcy5wcnVfYWJvcnQoc28pOw0KLQlzcGx4KHMp
Ow0KLQlyZXR1cm4gZXJyb3I7DQotfQ0KIA0KIC8qIHBydV9hY2NlcHQgaXMg
RU9QTk9UU1VQUCAqLw0KIA0KQEAgLTE1MCwyNiArMTQxLDYgQEAgcnRzX2F0
dGFjaChzdHJ1Y3Qgc29ja2V0ICpzbywgaW50IHByb3RvLA0KIAlyZXR1cm4g
MDsNCiB9DQogDQotc3RhdGljIGludA0KLXJ0c19iaW5kKHN0cnVjdCBzb2Nr
ZXQgKnNvLCBzdHJ1Y3Qgc29ja2FkZHIgKm5hbSwgc3RydWN0IHByb2MgKnAp
DQotew0KLQlpbnQgcywgZXJyb3I7DQotCXMgPSBzcGxuZXQoKTsNCi0JZXJy
b3IgPSByYXdfdXNycmVxcy5wcnVfYmluZChzbywgbmFtLCBwKTsgLyogeHh4
IGp1c3QgRUlOVkFMICovDQotCXNwbHgocyk7DQotCXJldHVybiBlcnJvcjsN
Ci19DQotDQotc3RhdGljIGludA0KLXJ0c19jb25uZWN0KHN0cnVjdCBzb2Nr
ZXQgKnNvLCBzdHJ1Y3Qgc29ja2FkZHIgKm5hbSwgc3RydWN0IHByb2MgKnAp
DQotew0KLQlpbnQgcywgZXJyb3I7DQotCXMgPSBzcGxuZXQoKTsNCi0JZXJy
b3IgPSByYXdfdXNycmVxcy5wcnVfY29ubmVjdChzbywgbmFtLCBwKTsgLyog
WFhYIGp1c3QgRUlOVkFMICovDQotCXNwbHgocyk7DQotCXJldHVybiBlcnJv
cjsNCi19DQotDQogLyogcHJ1X2Nvbm5lY3QyIGlzIEVPUE5PVFNVUFAgKi8N
CiAvKiBwcnVfY29udHJvbCBpcyBFT1BOT1RTVVBQICovDQogDQpAQCAtMjAy
LDY5ICsxNzMsMTYgQEAgcnRzX2RldGFjaChzdHJ1Y3Qgc29ja2V0ICpzbykN
CiAJcmV0dXJuIGVycm9yOw0KIH0NCiANCi1zdGF0aWMgaW50DQotcnRzX2Rp
c2Nvbm5lY3Qoc3RydWN0IHNvY2tldCAqc28pDQotew0KLQlpbnQgcywgZXJy
b3I7DQotCXMgPSBzcGxuZXQoKTsNCi0JZXJyb3IgPSByYXdfdXNycmVxcy5w
cnVfZGlzY29ubmVjdChzbyk7DQotCXNwbHgocyk7DQotCXJldHVybiBlcnJv
cjsNCi19DQotDQogLyogcHJ1X2xpc3RlbiBpcyBFT1BOT1RTVVBQICovDQot
DQotc3RhdGljIGludA0KLXJ0c19wZWVyYWRkcihzdHJ1Y3Qgc29ja2V0ICpz
bywgc3RydWN0IHNvY2thZGRyICoqbmFtKQ0KLXsNCi0JaW50IHMsIGVycm9y
Ow0KLQlzID0gc3BsbmV0KCk7DQotCWVycm9yID0gcmF3X3VzcnJlcXMucHJ1
X3BlZXJhZGRyKHNvLCBuYW0pOw0KLQlzcGx4KHMpOw0KLQlyZXR1cm4gZXJy
b3I7DQotfQ0KLQ0KIC8qIHBydV9yY3ZkIGlzIEVPUE5PVFNVUFAgKi8NCiAv
KiBwcnVfcmN2b29iIGlzIEVPUE5PVFNVUFAgKi8NCi0NCi1zdGF0aWMgaW50
DQotcnRzX3NlbmQoc3RydWN0IHNvY2tldCAqc28sIGludCBmbGFncywgc3Ry
dWN0IG1idWYgKm0sIHN0cnVjdCBzb2NrYWRkciAqbmFtLA0KLQkgc3RydWN0
IG1idWYgKmNvbnRyb2wsIHN0cnVjdCBwcm9jICpwKQ0KLXsNCi0JaW50IHMs
IGVycm9yOw0KLQlzID0gc3BsbmV0KCk7DQotCWVycm9yID0gcmF3X3VzcnJl
cXMucHJ1X3NlbmQoc28sIGZsYWdzLCBtLCBuYW0sIGNvbnRyb2wsIHApOw0K
LQlzcGx4KHMpOw0KLQlyZXR1cm4gZXJyb3I7DQotfQ0KLQ0KIC8qIHBydV9z
ZW5zZSBpcyBudWxsICovDQogDQotc3RhdGljIGludA0KLXJ0c19zaHV0ZG93
bihzdHJ1Y3Qgc29ja2V0ICpzbykNCi17DQotCWludCBzLCBlcnJvcjsNCi0J
cyA9IHNwbG5ldCgpOw0KLQllcnJvciA9IHJhd191c3JyZXFzLnBydV9zaHV0
ZG93bihzbyk7DQotCXNwbHgocyk7DQotCXJldHVybiBlcnJvcjsNCi19DQot
DQotc3RhdGljIGludA0KLXJ0c19zb2NrYWRkcihzdHJ1Y3Qgc29ja2V0ICpz
bywgc3RydWN0IHNvY2thZGRyICoqbmFtKQ0KLXsNCi0JaW50IHMsIGVycm9y
Ow0KLQlzID0gc3BsbmV0KCk7DQotCWVycm9yID0gcmF3X3VzcnJlcXMucHJ1
X3NvY2thZGRyKHNvLCBuYW0pOw0KLQlzcGx4KHMpOw0KLQlyZXR1cm4gZXJy
b3I7DQotfQ0KLQ0KIHN0YXRpYyBzdHJ1Y3QgcHJfdXNycmVxcyByb3V0ZV91
c3JyZXFzID0gew0KLQlydHNfYWJvcnQsIHBydV9hY2NlcHRfbm90c3VwcCwg
cnRzX2F0dGFjaCwgcnRzX2JpbmQsIHJ0c19jb25uZWN0LA0KLQlwcnVfY29u
bmVjdDJfbm90c3VwcCwgcHJ1X2NvbnRyb2xfbm90c3VwcCwgcnRzX2RldGFj
aCwgcnRzX2Rpc2Nvbm5lY3QsDQotCXBydV9saXN0ZW5fbm90c3VwcCwgcnRz
X3BlZXJhZGRyLCBwcnVfcmN2ZF9ub3RzdXBwLCBwcnVfcmN2b29iX25vdHN1
cHAsDQotCXJ0c19zZW5kLCBwcnVfc2Vuc2VfbnVsbCwgcnRzX3NodXRkb3du
LCBydHNfc29ja2FkZHIsDQorCXJhd191YWJvcnQsIHBydV9hY2NlcHRfbm90
c3VwcCwgcnRzX2F0dGFjaCwgcmF3X3ViaW5kLCByYXdfdWNvbm5lY3QsDQor
CXBydV9jb25uZWN0Ml9ub3RzdXBwLCBwcnVfY29udHJvbF9ub3RzdXBwLCBy
dHNfZGV0YWNoLCByYXdfdWRpc2Nvbm5lY3QsDQorCXBydV9saXN0ZW5fbm90
c3VwcCwgcmF3X3VwZWVyYWRkciwgcHJ1X3JjdmRfbm90c3VwcCwgcHJ1X3Jj
dm9vYl9ub3RzdXBwLA0KKwlyYXdfdXNlbmQsIHBydV9zZW5zZV9udWxsLCBy
YXdfdXNodXRkb3duLCByYXdfdXNvY2thZGRyLA0KIAlzb3NlbmQsIHNvcmVj
ZWl2ZSwgc29wb2xsDQogfTsNCiANCg==
--0-553016530-1039839708=:33726--
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021213201926.A33726-200000>