From owner-cvs-all@FreeBSD.ORG  Sun Oct 12 01:52:41 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id CAB8716A4B3; Sun, 12 Oct 2003 01:52:41 -0700 (PDT)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 8186543FAF; Sun, 12 Oct 2003 01:52:40 -0700 (PDT)
	(envelope-from phk@phk.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.12.10/8.12.10) with ESMTP id h9C8qa49014226;
	Sun, 12 Oct 2003 10:52:36 +0200 (CEST)
	(envelope-from phk@phk.freebsd.dk)
To: John-Mark Gurney <gurney_j@efn.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Sun, 12 Oct 2003 01:13:23 PDT."
             <20031012081323.GL533@funkthat.com> 
Date: Sun, 12 Oct 2003 10:52:36 +0200
Message-ID: <14225.1065948756@critter.freebsd.dk>
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern sys_pipe.c 
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 12 Oct 2003 08:52:41 -0000

In message <20031012081323.GL533@funkthat.com>, John-Mark Gurney writes:
>Poul-Henning Kamp wrote this message on Sun, Oct 12, 2003 at 10:05 +0200:
>> In message <200310120706.h9C763U6085132@repoman.freebsd.org>, John-Mark Gurney 
>> writes:
>> >jmg         2003/10/12 00:06:03 PDT
>> >
>> >  FreeBSD src repository
>> >
>> >  Modified files:
>> >    sys/kern             sys_pipe.c 
>> >  Log:
>> >  fix a problem referencing free'd memory.  This is only a problem for
>> >  kqueue write events on a socket and you regularly create tons of pipes
>> >  which overwrites the structure causing a panic when removing the knote
>> >  from the list.  If the peer has gone away (and it's a write knote), then
>> >  don't bother trying to remove the knote from the list.
>> 
>> Does this fix make(1) compiled with -DUSE_KQUEUE ?
>
>Hmmm.. After looking at the make source, no, it probably doesn't.  The
>bug this fixed was limited to EVFILT_WRITE events being registered on
>pipes, and make(1) doesn't use EVFILT_WRITE.
>
>Do we have a back trace on the problem with make?

Just do a make -j 12 buildworld and your kernel will explode.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.