Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 26 Oct 2017 11:36:27 +0000 (UTC)
From:      Kubilay Kocak <koobs@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r452916 - head/www/py-tvdb_api
Message-ID:  <201710261136.v9QBaRU3022458@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: koobs
Date: Thu Oct 26 11:36:27 2017
New Revision: 452916
URL: https://svnweb.freebsd.org/changeset/ports/452916

Log:
  www/py-tvdb_api: Add missing dependencies
  
  tvdb_api 2.0 added dependencies on requests and request-cache [1][2]. Without
  them, multimedia/py-tvnamer fails at runtime:
  
  "DistributionNotFound: The 'requests' distribution was not found and is required by tvdb-api"
  "DistributionNotFound: The 'requests_cache' distribution was not found and is required by tvdb-api"
  
  Add requests and request-cache to RUN_DEPENDS accordingly.
  
  While I'm here, level up port compliance:
  
  * Update Python version restriction (2.0 supports Python 3)
  * Add TEST_DEPENDS and test target
  * Add LICENSE / LICENSE_FILE
  
  [1] https://github.com/dbr/tvdb_api/commit/ea7f2d57
  [2] https://github.com/dbr/tvdb_api/commit/f05a327d
  
  portlint: OK (looks fine.)
  testport: OK (poudriere, 12amd64, Python 2.7/3.6)
  unittest: OK (42 passed, 3 skipped in 45.39 seconds)
  
  Reported by: Georg Huber (via email)
  Approved by: portmgr (blanket)

Modified:
  head/www/py-tvdb_api/Makefile

Modified: head/www/py-tvdb_api/Makefile
==============================================================================
--- head/www/py-tvdb_api/Makefile	Thu Oct 26 11:34:01 2017	(r452915)
+++ head/www/py-tvdb_api/Makefile	Thu Oct 26 11:36:27 2017	(r452916)
@@ -3,6 +3,7 @@
 
 PORTNAME=	tvdb_api
 PORTVERSION=	2.0
+PORTREVISION=	1
 CATEGORIES=	www python
 MASTER_SITES=	CHEESESHOP
 PKGNAMEPREFIX=	${PYTHON_PKGNAMEPREFIX}
@@ -10,8 +11,18 @@ PKGNAMEPREFIX=	${PYTHON_PKGNAMEPREFIX}
 MAINTAINER=	bofh@FreeBSD.org
 COMMENT=	API interface to TheTVDB.com
 
-USES=		python:2
-USE_PYTHON=	distutils autoplist
+LICENSE=	UNLICENSE
+LICENSE_FILE=	${WRKSRC}/UNLICENSE
+
+RUN_DEPENDS=	${PYTHON_PKGNAMEPREFIX}requests>0:www/py-requests \
+		${PYTHON_PKGNAMEPREFIX}requests-cache>0:www/py-requests-cache
+TEST_DEPENDS=	${PYTHON_PKGNAMEPREFIX}pytest>0:devel/py-pytest
+
+USES=		python
+USE_PYTHON=	autoplist distutils
 NO_ARCH=	yes
+
+do-test:
+	@cd ${WRKSRC} && ${PYTHON_CMD} ${PYDISTUTILS_SETUP} test
 
 .include <bsd.port.mk>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201710261136.v9QBaRU3022458>