Date: Tue, 03 Sep 2019 14:06:08 -0000 From: Enji Cooper <ngie@FreeBSD.org> To: src-committers@freebsd.org, svn-src-projects@freebsd.org Subject: svn commit: r345779 - projects/capsicum-test/contrib/capsicum-test Message-ID: <201904012002.x31K2RM4027205@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: ngie Date: Mon Apr 1 20:02:26 2019 New Revision: 345779 URL: https://svnweb.freebsd.org/changeset/base/345779 Log: Clarify why `kern.trap_enotcap` being set should cause the tests to be skipped. Modified: projects/capsicum-test/contrib/capsicum-test/capsicum-test-main.cc Modified: projects/capsicum-test/contrib/capsicum-test/capsicum-test-main.cc ============================================================================== --- projects/capsicum-test/contrib/capsicum-test/capsicum-test-main.cc Mon Apr 1 19:19:51 2019 (r345778) +++ projects/capsicum-test/contrib/capsicum-test/capsicum-test-main.cc Mon Apr 1 20:02:26 2019 (r345779) @@ -47,6 +47,8 @@ class SetupEnvironment : public ::testing::Environment GTEST_SKIP() << "Skipping tests because capsicum support is not " << "enabled in the kernel."; } + // If this OID is enabled, it will send SIGTRAP to the process when + // `ENOTCAPABLE` is returned. const char *oid = "kern.trap_enotcap"; rc = sysctlbyname(oid, &trap_enotcap_enabled, &trap_enotcap_enabled_len, nullptr, 0); @@ -54,8 +56,9 @@ class SetupEnvironment : public ::testing::Environment GTEST_FAIL() << "sysctlbyname failed: " << strerror(errno); } if (trap_enotcap_enabled) { - GTEST_SKIP() << "Sysctl " << oid << " enabled. " - << "Skipping tests to avoid non-determinism with results."; + GTEST_SKIP() << "Debug sysctl " << oid << " enabled. " + << "Skipping tests because it's enablement invalidates the " + << "test results."; } #endif /* FreeBSD */ }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201904012002.x31K2RM4027205>