From owner-cvs-all  Sat Feb 24 23: 6:20 2001
Delivered-To: cvs-all@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id 0720F37B65D; Sat, 24 Feb 2001 23:06:16 -0800 (PST)
	(envelope-from bde@zeta.org.au)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id SAA26407;
	Sun, 25 Feb 2001 18:06:13 +1100
Date: Sun, 25 Feb 2001 18:01:29 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-Sender: bde@besplex.bde.org
To: Jake Burkholder <jake@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/i386/i386 db_trace.c exception.s machdep.c
         trap.c src/sys/i386/include asnames.h
In-Reply-To: <200102250253.f1P2r6v33800@freefall.freebsd.org>
Message-ID: <Pine.BSF.4.21.0102251745170.5881-100000@besplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

On Sat, 24 Feb 2001, Jake Burkholder wrote:

> jake        2001/02/24 18:53:06 PST
> 
>   Modified files:
>     sys/i386/i386        db_trace.c exception.s machdep.c trap.c 
>     sys/i386/include     asnames.h 
>   Log:
>   - Rename the lcall system call handler from Xsyscall to Xlcall_syscall
>     to be more like Xint0x80_syscall and less like c function syscall().

This is sort of backwards.  Xsyscall is supposed to be named like the C
function syscall(), but it should be used for normal int 0x80 syscalls.

>   - Reduce code duplication between the int0x80 and lcall handlers by
>     shuffling the elfags into the right place, saving the sizeof the
>     instruction in tf_err and jumping into the common int0x80 code.

This breaks profiling and pessimizes Xsyscall a little.  Please back this
out.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message