From nobody Mon Jan 22 16:23:29 2024 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TJbB94VMDz57jvn for ; Mon, 22 Jan 2024 16:23:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TJbB91cgSz4V5r for ; Mon, 22 Jan 2024 16:23:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1705940609; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MsnLSepYXMYk2ABkAqWmXtMrdhWtmlucpsooON/zV8Q=; b=muiK9wCXaRJTo2GPJdrPHeeSJXO122qCAw8mHLlnFxroSdoOA6ebPY6J4cUCmSgkIjH3KU Qsil/y0cPgK8PP5STP0NxzDYbBQAWHI3tYlmX7A4NJOomikXu8ha2LKCFU4nIX7wnFQkyf lkEJTkhvv2FQbyRoT1Pk4TZMNl17j/owJW6L5rsEXbiNyO3gYxR+P6gUa2yq06saSzxwOf bLvZfQcT4hPwJaVg9+rE82xGeOewxmyc04NgstxRz5ReYKqWisg/iPGBHuMWot4GRyllhk nWjoJieq64+NbdxiQ+uBLvOarSK5SzPVkw/WJRySKW0H7Eb0WY79rQmSANZ/RQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1705940609; a=rsa-sha256; cv=none; b=Inqlbxv12VmxbMdwCHatFERpDnaEL709rPQwVwDq8MwwOMReyOhr9W0ciW+j9YqtNsgEAX 7hFIWYvgKjN7wgAC3LUwC1+IAmaQrreC+LbJ6vK7U18xsvHwYDXh9EZ0+wfKY3WIg71FU8 MSj67EYbnHyoLndu64xc3h8sRvjJBKmC1NF2oyxx6Yd45gA+FAeFLrTcDig0T1hkHEKLzi J2HVzTYCHROsyET2ibqXQMbxu/681TE7QdtIZpPu/hg/BxZoQ3sa3qn1WdkqgOxxGreFvB 3bVDStEc6oqB+sHJXGtRe8wu5FcJ2GbNqxUqyQVv4QApYl82ExqAjgT0tvRXww== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TJbB90gmsz17gT for ; Mon, 22 Jan 2024 16:23:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 40MGNTNa087025 for ; Mon, 22 Jan 2024 16:23:29 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 40MGNTLf087024 for net@FreeBSD.org; Mon, 22 Jan 2024 16:23:29 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 276526] if_wg: Add missing bpfdetach() in wg_clone_destroy() Date: Mon, 22 Jan 2024 16:23:29 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: kevans@freebsd.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276526 --- Comment #2 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D43be2d7aaf25b719aec8f49aab110c006= 1f1edec commit 43be2d7aaf25b719aec8f49aab110c0061f1edec Author: Aaron LI AuthorDate: 2024-01-22 16:18:56 +0000 Commit: Kyle Evans CommitDate: 2024-01-22 16:22:44 +0000 wg: detach bpf upon destroy as well bpfattach() is called in wg_clone_create(), but the bpfdetach() is missing from wg_close_destroy(). Add the missing bpfdetach() to avoid leaking both the associated bpf bits as well as the ifnet that bpf will hold a reference to. PR: 276526 MFC after: 3 days sys/dev/wg/if_wg.c | 1 + 1 file changed, 1 insertion(+) --=20 You are receiving this mail because: You are on the CC list for the bug.=