From owner-cvs-all@FreeBSD.ORG Thu Jun 26 08:40:17 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5263E37B401 for ; Thu, 26 Jun 2003 08:40:17 -0700 (PDT) Received: from mail.speakeasy.net (mail8.speakeasy.net [216.254.0.208]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6F7C243FE0 for ; Thu, 26 Jun 2003 08:40:14 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 23895 invoked from network); 26 Jun 2003 15:40:13 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender )encrypted SMTP for ; 26 Jun 2003 15:40:13 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.9/8.12.9) with ESMTP id h5QFeBGI059373; Thu, 26 Jun 2003 11:40:11 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200306260003.h5Q03xUj002309@repoman.freebsd.org> Date: Thu, 26 Jun 2003 11:40:23 -0400 (EDT) From: John Baldwin To: Scott Long cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: RE: cvs commit: src/sys/dev/ips ips.c ips.h ips_commands.c ips_pci.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jun 2003 15:40:18 -0000 On 26-Jun-2003 Scott Long wrote: > scottl 2003/06/25 17:03:59 PDT > > FreeBSD src repository > > Modified files: > sys/dev/ips ips.c ips.h ips_commands.c ips_pci.c > Log: > - Zero the buffers used to hold configuration data from the card. Not doing > so can leave stale data in the buffer and confuse the driver. > - enable the ability to set the 'disable' hint for the driver to keep it > from attaching. i.e. 'hw.ips.0.disable=1' will prevent the driver from > attaching. Should be "hint.ips.0.disabled". Perhaps we need to add a resource_disabled() function to abstract this so people stop getting it wrong. Something like: int resource_disabled(const char *name, int unit) { int error, value; value = resource_int_value(name, unit, "disabled", &error); if (error == 0) return (value); return (0); } You could then expand this function to check 'disable' as well if desired and allow for 'true' and 'false', 'on' and 'off' in addition to '0' and '1'. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/