From nobody Sun Apr 17 17:47:59 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 5AEB35D7090 for ; Sun, 17 Apr 2022 17:48:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KhHbN1QS1z4hF6 for ; Sun, 17 Apr 2022 17:48:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 1188222827 for ; Sun, 17 Apr 2022 17:48:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 23HHm0Cv011995 for ; Sun, 17 Apr 2022 17:48:00 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 23HHm0Xa011981 for bugs@FreeBSD.org; Sun, 17 Apr 2022 17:48:00 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 263371] Possible memleak bugs caused by g_raid_destroy_volume() Date: Sun, 17 Apr 2022 17:47:59 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: yuri@aetern.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1650217680; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jrR75/BNfyfLo1PyQpjWe0caRE2lF5bSnUw5S9la26g=; b=P2z5j7knVabB7NWoYRNkdTjhgERaTY6T+svcr/I8gYZrdw3QJqzVaOWYdVqSNRMBJ0fvsV 5mUrfRrkCeDXYLWpZQOaNJtfvJDMhs83plUesDvNm/a1w6inyg//My9GPBaVpKYg/TnR2D 5ux7oDv24JJVAy3nR+5G+SX1khtDrIaK2WFdpCP7BIBO3/O3dsgGzkM22XpdnhPCBPMWlS Ols3XH+AtLuhnCxLCrTGKNO2uVNZjrD9PDrGUCmiAOlutt1H84E9mJ14O2Gg7Bx1jAxqmi PK/4O4dOrIsB2Ben+2Q9rtYqohLUdSGT+Md6kN27TDreUa4PFZ4N1R+XPyVzQQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1650217680; a=rsa-sha256; cv=none; b=TNZHe/LH/Rhme/436vB+uctU4HkBpFSEdmhexzmbOYgsF9fyQSgCKKIfkv9jH7/mToBY3n FtpzPuwTGpMzFdxg3DtBvTokVGOJaVs6fZAxu7WwVRxE0hWIbPkLiOlvXf/iogQ8in28xv OsrbfPjNqPPx4AvS3Ev3A1m9zLpWRogLrYP1AGBRLxRNPqnhxQHRlYotlsp9SzBgOiuxQ/ ELQQdwggZnXMp7YvY9DpYSFHJxdztRl4wMsfQzR0iZNVTSPokxZgtiphlBnzWwLcu+SwM0 jMTwK0q1w1w4LmHNstjV389scDRk06DjJ+KioC88RHrk/VQDQ6fOCS2ROTzOaw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D263371 --- Comment #1 from Yuri --- The advise would be taking static analyzer output with a grain of salt (or a ton, actually) and asking questions on relevant mailing lists instead of us= ing bugtracker when in doubt. For the report itself, if I understand the code correctly, the vol->v_provider_open !=3D 0 check above all of the g_raid_destroy_volume() = calls makes sure all of the code paths returning EBUSY will not be taken. It wou= ld help though to have (void) casts when we are not interested in return value= s to mark it as "intended". --=20 You are receiving this mail because: You are the assignee for the bug.=