From owner-cvs-all@FreeBSD.ORG  Thu Sep 14 07:55:57 2006
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@freebsd.org
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B586B16A40F;
	Thu, 14 Sep 2006 07:55:57 +0000 (UTC)
	(envelope-from ru@rambler-co.ru)
Received: from relay0.rambler.ru (relay0.rambler.ru [81.19.66.187])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E368143D66;
	Thu, 14 Sep 2006 07:55:50 +0000 (GMT)
	(envelope-from ru@rambler-co.ru)
Received: from relay0.rambler.ru (localhost [127.0.0.1])
	by relay0.rambler.ru (Postfix) with ESMTP id 9482F5E59;
	Thu, 14 Sep 2006 11:55:49 +0400 (MSD)
Received: from edoofus.park.rambler.ru (unknown [81.19.65.108])
	by relay0.rambler.ru (Postfix) with ESMTP id 710175E58;
	Thu, 14 Sep 2006 11:55:49 +0400 (MSD)
Received: (from ru@localhost)
	by edoofus.park.rambler.ru (8.13.8/8.13.8) id k8E7tqak009060;
	Thu, 14 Sep 2006 11:55:52 +0400 (MSD) (envelope-from ru)
Date: Thu, 14 Sep 2006 11:55:52 +0400
From: Ruslan Ermilov <ru@freebsd.org>
To: "David O'Brien" <obrien@freebsd.org>
Message-ID: <20060914075552.GB8784@rambler-co.ru>
References: <200609132327.k8DNRMqS076204@repoman.freebsd.org>
	<20060913233211.GA83839@toxic.magnesium.net>
	<20060913235810.GA87164@dragon.NUXI.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="KsGdsel6WgEHnImy"
Content-Disposition: inline
In-Reply-To: <20060913235810.GA87164@dragon.NUXI.org>
User-Agent: Mutt/1.5.13 (2006-08-11)
X-Virus-Scanned: No virus found
Cc: Juli Mallett <jmallett@freebsd.org>, cvs-src@freebsd.org,
	src-committers@freebsd.org, cvs-all@freebsd.org
Subject: Re: cvs commit: src/share/mk bsd.lib.mk bsd.prog.mk
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Sep 2006 07:55:57 -0000


--KsGdsel6WgEHnImy
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Sep 13, 2006 at 04:58:10PM -0700, David O'Brien wrote:
> On Wed, Sep 13, 2006 at 01:32:11PM -1000, Juli Mallett wrote:
> > 	[ cvs commit: src/share/mk bsd.lib.mk bsd.prog.mk ]
> > >   When building WITHOUT_ASSERT_DEBUG, we need to disable -Werror as i=
ts easy
> > >   to see "warning: unused variable `foo'".
> >=20
> > I think it might be a better idea to -Wno-unused, since the only sorts =
of
> > warnings one wants to ignore building NDEBUG are the variables which are
> > otherwise unused.
>=20
> Hum.. I assumed that WITHOUT_ASSERT_DEBUG was a rare case and used as
> part of producing a production release where one knows /usr/src builds
> as-usual.  -Wno-unused would scratch this itch, but we need to find a way
> to codify it so that we're not putting GCC options into share/mk.  I
> guess make a NO_WUNUSED knob.
>=20
I think what you have committed is appropriate.


Cheers,
--=20
Ruslan Ermilov
ru@FreeBSD.org
FreeBSD committer

--KsGdsel6WgEHnImy
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (FreeBSD)

iD8DBQFFCQsIqRfpzJluFF4RAo9qAJ9cbgiqqjdi6GbP18qVqAhFzVb3MACeLtmL
Ywl4WjikpCstPPsJONjq/uE=
=dPat
-----END PGP SIGNATURE-----

--KsGdsel6WgEHnImy--