From owner-svn-ports-all@freebsd.org Mon Aug 24 11:45:05 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4B4B23BB341; Mon, 24 Aug 2020 11:45:05 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BZr011JPbz4d7q; Mon, 24 Aug 2020 11:45:05 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from mail.j.mat.cc (owncloud.cube.mat.cc [79.143.240.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.mat.cc", Issuer "Let's Encrypt Authority X3" (verified OK)) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id E92A12A2AE; Mon, 24 Aug 2020 11:45:04 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from aching.in.mat.cc (unknown [IPv6:2a01:678:ab:50:a2c6:8a4a:1cba:5d07]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mat@mat.cc) by mail.j.mat.cc (Postfix) with ESMTPSA id 1D285942D81; Mon, 24 Aug 2020 11:45:02 +0000 (UTC) Date: Mon, 24 Aug 2020 13:45:00 +0200 From: Mathieu Arnold To: "Lev A. Serebryakov" Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r545609 - in head/devel/gcc-msp430-ti-toolchain: . files Message-ID: <20200824114500.7ve4g5j4sikly5ek@aching.in.mat.cc> References: <202008211551.07LFpPdb047611@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="qw2kmjdrrqrgvxvq" Content-Disposition: inline In-Reply-To: <202008211551.07LFpPdb047611@repo.freebsd.org> X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Aug 2020 11:45:05 -0000 --qw2kmjdrrqrgvxvq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 21, 2020 at 03:51:25PM +0000, Lev A. Serebryakov wrote: > +# Strip binaries > +.if !defined(DEBUG) > + @for bin in $$(${FIND} ${INTERIM_PREFIX}/bin -type f -name ${TARGET}-\*= ) ; do \ > + if ! ${FILE} $$bin | ${GREP} -qs ': ELF' ; then continue ; fi ; \ > + ${STRIP_CMD} $${bin} ; \ > + done Is there a particular reason for doing things in a way that convoluted? I mean, is there a reason for not doing it in a straight way like this: @for bin in $$(${FIND} ${INTERIM_PREFIX}/bin -type f -name ${TARGET}-\*) ;= do \ if ${FILE} $$bin | ${GREP} -qs ': ELF' ; then \ ${STRIP_CMD} $${bin} ; \ fi ; \ done We usually write `if something I want; then somethig; fi`. The `if something I don't want; then continue; fi; something` is reather strange. --=20 Mathieu Arnold --qw2kmjdrrqrgvxvq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEVhwchfRfuV0unqO5KesJApEdfgIFAl9DqDhfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU2 MUMxQzg1RjQ1RkI5NUQyRTlFQTNCOTI5RUIwOTAyOTExRDdFMDIACgkQKesJApEd fgJsDw/+NlBVxQbWGhdfVDZH0iqKCxweHMBdTtb2KP70Gm5K1kr5uM03Jv6G1ybi fd6oQFqC2jKkpdAb+iUaBaoE/k7+d6qGg6jiUl8PtZd4nd+Zjwit9/kOcZeXQ+es URJyUaEb633SPFsGjLiYvL0QfNhj/SsVj6nodPaNZp8r8JUV3boc+9FznrKMBN9b 0i3MgymIaFkeUoaIygZykcUFTZ6FuGG35d4mUY5zlZ141lrD9FTnmf7Og4tqKqSj Q2mHr928Q9MPvZmusStIWepECY71pAYzyeoZ1SlTe0AV9K9LH/TK2GsowGGHOljz 1lQd98Ki+zQzlRX5Cqkwf7Mwejx5gIU/Uy38YUZO7QDNFJU/mnHLZQe969ru0hb6 dgn+w4PLHPoCXOb7giLLCdIDn7ksvailC06OAxwsrAHwtEMzNZbwmJhbk2EROZWH 3EdxJ4O0lzV6lnev8aUgbp8YvlJPUo/ncjnZHEEwcoDfqc2IUjs323O/FrosAj/Y 9HrqfPbjc52HsJecbtpfR5V6lT4BAafj/w82VzIaMXKUSsdgFKwQd9iDKQikGobJ EKd2qrKv2/dxgPiNb+QSIXhbTY4AGIVSqQ80wFNNdIh33rdL3+9J2CAm+w+H0bJA jfOgtIKYJeJxHL4xibWs3O+WyMFUQm2R13hT3f5TfDSRMRCWK4g= =7E8U -----END PGP SIGNATURE----- --qw2kmjdrrqrgvxvq--