Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 10 Apr 2012 12:28:05 +0200
From:      Robert Millan <rmh@freebsd.org>
To:        Doug Barton <dougb@freebsd.org>
Cc:        freebsd-acpi@freebsd.org, Steven Chamberlain <steven@pyro.eu.org>, freebsd-rc@freebsd.org, Nate Lawson <nate@root.org>
Subject:   Re: [PATCH] Abort powerd when no cpufreq(4) support is found
Message-ID:  <CAOfDtXOcqnAu97daAKok4gnQrWHcdJEzpf5zUNsMxTiOU2fstg@mail.gmail.com>
In-Reply-To: <4F83635C.9000701@FreeBSD.org>
References:  <CAOfDtXO=7ALiBVHdY-hHa158yXoM%2BXXigkU4SObPHRr0h-2iUQ@mail.gmail.com> <E2E769FA-970A-4E1C-805B-DE6397B456C9@root.org> <CAOfDtXPW8ipGE5p=76HQ5pe9wGx0u%2BKYddRYN26pMW6O7wtENA@mail.gmail.com> <30133A83-88E4-4715-8514-E9229E9AF078@root.org> <CAOfDtXMZMy4RfpPEUKFJHnVrMYdtW-4DsdL_h7hD6SCA-By4JA@mail.gmail.com> <4F83635C.9000701@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
El 10 d=E2=80=99abril de 2012 0:31, Doug Barton <dougb@freebsd.org> ha escr=
it:
> On 04/09/2012 13:59, Robert Millan wrote:
>> El 9 d=E2=80=99abril de 2012 18:53, Nate Lawson <nate@root.org> ha escri=
t:
>>> Fine by me. The rc framework or user should be the one to interpret the=
 error code and realize that it's ok that it's not running (not supported).
>>
>> Committed then, thanks for reviewing.
>
> Have you verified how rc.d handles this new error? If changes are
> necessary a friendly message to freebsd-rc@ would be in order ....

I don't think any changes are necessary.  It uses the generic routine
in rc.subr, which gives the same treatment to all non-zero exit codes.
 Maybe it'd be a good idea to treat it differently (at least this is
what we did in Debian), but for FreeBSD I'm probably not the most
indicate to change behaviour on that area.

I'm adding freebsd-rc to CC in case someone wants to apply this kind of cha=
nge.

--=20
Robert Millan



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOfDtXOcqnAu97daAKok4gnQrWHcdJEzpf5zUNsMxTiOU2fstg>