From owner-freebsd-rc@FreeBSD.ORG Tue Apr 10 10:28:07 2012 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 32BA9106566B; Tue, 10 Apr 2012 10:28:06 +0000 (UTC) (envelope-from rmh.aybabtu@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id 919D38FC0C; Tue, 10 Apr 2012 10:28:06 +0000 (UTC) Received: by iahk25 with SMTP id k25so9639451iah.13 for ; Tue, 10 Apr 2012 03:28:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=iX5jMS5zlbMpBcZvvaqNi3kusLRm3koeVxyTPRE3YGA=; b=HZuTjwqDUyfy4Odl5KLFS8/0Rrz0HweArEw16mk9jr+yil80sUpNRFy5Lh/R5mjwOG dBHhil2UZ9fkVXpc0GS6lxQz1ImXdePE8jaHIWd5E+/NIT4ACqHfLVjmW5VJ4ljVOcSa Osmd38Ivga+6IB/4zYrlksddn2OVb+zOtAzFhPzlW2hb2ORxhS7Bk+KgExam6lz/o4b/ x1jKWztDqKbATLeTzPxEMRwZ0rNrGo0XBb4d4a8ZuM/A6K1l0nBiONTSz/PwnCsdWNb8 hAezoLYMQDe7WfkzZ+bnl8Ej7ovYt+9UXu8r0mKFXXUARmoJfXDaB7V5hdX4K79cUmO4 xOOg== MIME-Version: 1.0 Received: by 10.50.156.170 with SMTP id wf10mr1767667igb.7.1334053685970; Tue, 10 Apr 2012 03:28:05 -0700 (PDT) Sender: rmh.aybabtu@gmail.com Received: by 10.43.130.201 with HTTP; Tue, 10 Apr 2012 03:28:05 -0700 (PDT) In-Reply-To: <4F83635C.9000701@FreeBSD.org> References: <30133A83-88E4-4715-8514-E9229E9AF078@root.org> <4F83635C.9000701@FreeBSD.org> Date: Tue, 10 Apr 2012 12:28:05 +0200 X-Google-Sender-Auth: 4fjklqRq2OB-pYXJaNbYCks98MU Message-ID: From: Robert Millan To: Doug Barton Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: freebsd-acpi@freebsd.org, Steven Chamberlain , freebsd-rc@freebsd.org, Nate Lawson Subject: Re: [PATCH] Abort powerd when no cpufreq(4) support is found X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Apr 2012 10:28:07 -0000 El 10 d=E2=80=99abril de 2012 0:31, Doug Barton ha escr= it: > On 04/09/2012 13:59, Robert Millan wrote: >> El 9 d=E2=80=99abril de 2012 18:53, Nate Lawson ha escri= t: >>> Fine by me. The rc framework or user should be the one to interpret the= error code and realize that it's ok that it's not running (not supported). >> >> Committed then, thanks for reviewing. > > Have you verified how rc.d handles this new error? If changes are > necessary a friendly message to freebsd-rc@ would be in order .... I don't think any changes are necessary. It uses the generic routine in rc.subr, which gives the same treatment to all non-zero exit codes. Maybe it'd be a good idea to treat it differently (at least this is what we did in Debian), but for FreeBSD I'm probably not the most indicate to change behaviour on that area. I'm adding freebsd-rc to CC in case someone wants to apply this kind of cha= nge. --=20 Robert Millan