From owner-freebsd-stable@FreeBSD.ORG Sat Jul 1 03:51:54 2006 Return-Path: X-Original-To: freebsd-stable@freebsd.org Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C02E016A40F for ; Sat, 1 Jul 2006 03:51:54 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from nz-out-0102.google.com (nz-out-0102.google.com [64.233.162.203]) by mx1.FreeBSD.org (Postfix) with ESMTP id D4C7643D4C for ; Sat, 1 Jul 2006 03:51:53 +0000 (GMT) (envelope-from pyunyh@gmail.com) Received: by nz-out-0102.google.com with SMTP id x7so260197nzc for ; Fri, 30 Jun 2006 20:51:53 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=Dj7P3f/PZY56nCl/ZzPNPnZRIfDDTeuuoenDJrBSjXkYL62Ips+JBg5SaTb5EgeEEv6HsArC1lQCN/nwsJwmhdS7SY0Wx2KxknJWqtBp8hZb/buOY7ZGq5TWzzrZerJjgpodF5ikrCMdDCKj6Hoa/DhB0o8ZwJ5kZSd7G4d8sD4= Received: by 10.36.100.15 with SMTP id x15mr1492290nzb; Fri, 30 Jun 2006 20:51:53 -0700 (PDT) Received: from michelle.cdnetworks.co.kr ( [211.53.35.84]) by mx.gmail.com with ESMTP id 18sm4193066nzo.2006.06.30.20.51.50; Fri, 30 Jun 2006 20:51:52 -0700 (PDT) Received: from michelle.cdnetworks.co.kr (localhost.cdnetworks.co.kr [127.0.0.1]) by michelle.cdnetworks.co.kr (8.13.5/8.13.5) with ESMTP id k613sNLn056009 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 1 Jul 2006 12:54:23 +0900 (KST) (envelope-from pyunyh@gmail.com) Received: (from yongari@localhost) by michelle.cdnetworks.co.kr (8.13.5/8.13.5/Submit) id k613sGU8056008; Sat, 1 Jul 2006 12:54:16 +0900 (KST) (envelope-from pyunyh@gmail.com) Date: Sat, 1 Jul 2006 12:54:16 +0900 From: Pyun YongHyeon To: Atanas Message-ID: <20060701035416.GC54876@cdnetworks.co.kr> References: <20060628185426.M43909@ganymede.hub.org> <20060628225239.GA93265@dan.emsphone.com> <44A3394C.4090209@asd.aplus.net> <44A3817F.4030105@thebeastie.org> <20060629092154.GE742@turion.vk2pj.dyndns.org> <20060629083130.X1229@ganymede.hub.org> <44A4A02A.9060802@thebeastie.org> <20060630012615.Q1103@ganymede.hub.org> <44A57B71.6020201@asd.aplus.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="zhXaljGHf11kAtnf" Content-Disposition: inline In-Reply-To: <44A57B71.6020201@asd.aplus.net> User-Agent: Mutt/1.4.2.1i Cc: Peter Jeremy , freebsd-stable@freebsd.org, Michael Vince , User Freebsd Subject: Re: em device hangs on ifconfig alias ... X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Jul 2006 03:51:54 -0000 --zhXaljGHf11kAtnf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jun 30, 2006 at 12:28:49PM -0700, Atanas wrote: > User Freebsd said the following on 6/29/06 9:29 PM: > > > >The other funny thing about the current em driver is that if you move an > >IP to it from a different server, the appropriate ARP packets aren't > >sent out to redirect the IP traffic .. recently, someone pointed me to > >arping, which has solved my problem *external* to the driver ... > > > That's the second reason why I (still) avoid em in mass-aliased systems. > > I have a single pool of IP addresses shared by many servers with > multiple aliases each. When someone leaves and frees an IP, it gets > reused and brought up on a different server. In case it was previously > handled by em, the traffic doesn't get redirected to the new server. > > Similar thing happens even with machines with single static IPs. For > instance when retiring an old production system, I usually request a new > box to be brought up on a different IP, make a fresh install on > everything and test, swap IP addresses and reboot. In case of em, after > a soft reboot both systems are inaccessible. > > A workaround is to power both of the systems down and then power them > up. This however cannot be done remotely and in case there were IP > aliases, they still don't get any traffic. > I haven't fully tested it but what about attached patch? It may fix your ARP issue. The patch also fixes other issues related with ioctls. Now em(4) will send a ARP packet when its IP address is changed even if there is no active link. Since em(4) is not mii-aware driver I can't sure this behaviour is correct. -- Regards, Pyun YongHyeon --zhXaljGHf11kAtnf Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="em.arp.patch" Index: if_em.c =================================================================== RCS file: /pool/ncvs/src/sys/dev/em/if_em.c,v retrieving revision 1.116 diff -u -r1.116 if_em.c --- if_em.c 6 Jun 2006 08:03:49 -0000 1.116 +++ if_em.c 1 Jul 2006 03:51:41 -0000 @@ -692,7 +692,8 @@ EM_LOCK_ASSERT(sc); - if (!sc->link_active) + if ((ifp->if_drv_flags & (IFF_DRV_RUNNING|IFF_DRV_OACTIVE)) != + IFF_DRV_RUNNING) return; while (!IFQ_DRV_IS_EMPTY(&ifp->if_snd)) { @@ -751,11 +752,6 @@ return (error); switch (command) { - case SIOCSIFADDR: - case SIOCGIFADDR: - IOCTL_DEBUGOUT("ioctl rcv'd: SIOCxIFADDR (Get/Set Interface Addr)"); - ether_ioctl(ifp, command, data); - break; case SIOCSIFMTU: { int max_frame_size; @@ -802,17 +798,19 @@ IOCTL_DEBUGOUT("ioctl rcv'd: SIOCSIFFLAGS (Set Interface Flags)"); EM_LOCK(sc); if (ifp->if_flags & IFF_UP) { - if (!(ifp->if_drv_flags & IFF_DRV_RUNNING)) { + if ((ifp->if_drv_flags & IFF_DRV_RUNNING)) { + if ((ifp->if_flags ^ sc->if_flags) & + IFF_PROMISC) { + em_disable_promisc(sc); + em_set_promisc(sc); + } + } else em_init_locked(sc); - } - - em_disable_promisc(sc); - em_set_promisc(sc); } else { - if (ifp->if_drv_flags & IFF_DRV_RUNNING) { + if (ifp->if_drv_flags & IFF_DRV_RUNNING) em_stop(sc); - } } + sc->if_flags = ifp->if_flags; EM_UNLOCK(sc); break; case SIOCADDMULTI: @@ -878,8 +876,8 @@ break; } default: - IOCTL_DEBUGOUT1("ioctl received: UNKNOWN (0x%x)", (int)command); - error = EINVAL; + error = ether_ioctl(ifp, command, data); + break; } return (error); Index: if_em.h =================================================================== RCS file: /pool/ncvs/src/sys/dev/em/if_em.h,v retrieving revision 1.44 diff -u -r1.44 if_em.h --- if_em.h 15 Feb 2006 08:39:50 -0000 1.44 +++ if_em.h 1 Jul 2006 03:51:41 -0000 @@ -259,6 +259,7 @@ struct callout timer; struct callout tx_fifo_timer; int io_rid; + int if_flags; struct mtx mtx; int em_insert_vlan_header; struct task link_task; --zhXaljGHf11kAtnf--