From owner-cvs-all Sun Jul 29 2:46: 3 2001 Delivered-To: cvs-all@freebsd.org Received: from obsecurity.dyndns.org (adsl-64-169-104-149.dsl.lsan03.pacbell.net [64.169.104.149]) by hub.freebsd.org (Postfix) with ESMTP id BB0CA37B401; Sun, 29 Jul 2001 02:45:53 -0700 (PDT) (envelope-from kris@obsecurity.org) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id C162466F1C; Sun, 29 Jul 2001 02:45:52 -0700 (PDT) Date: Sun, 29 Jul 2001 02:45:52 -0700 From: Kris Kennaway To: Greg Lehey Cc: Darren Reed , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/contrib/ipfilter/netinet fil.c ip_auth.c ip_auth.h ip_compat.h ip_fil.c ip_fil.h ip_frag.c ip_frag.h ip_ftp_pxy.c ip_log.c ip_nat.c ip_nat.h ip_proxy.c ip_proxy.h ip_raudio_pxy.c ip_state.c ip_state.h ipl.h Message-ID: <20010729024551.A77471@xor.obsecurity.org> References: <200107281158.f6SBwV351553@freefall.freebsd.org> <20010729100813.C68202@wantadilla.lemis.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="X1bOJ3K7DJ5YkBrT" Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010729100813.C68202@wantadilla.lemis.com>; from grog@FreeBSD.org on Sun, Jul 29, 2001 at 10:08:13AM +0930 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --X1bOJ3K7DJ5YkBrT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jul 29, 2001 at 10:08:13AM +0930, Greg Lehey wrote: > On Saturday, 28 July 2001 at 4:58:31 -0700, Darren Reed wrote: > > darrenr 2001/07/28 04:58:30 PDT > > > > Modified files: > > sys/contrib/ipfilter/netinet fil.c ip_auth.c ip_auth.h > > ip_compat.h ip_fil.c ip_fil.h > > ip_frag.c ip_frag.h ip_ftp_pxy.c > > ip_log.c ip_nat.c ip_nat.h > > ip_proxy.c ip_proxy.h > > ip_raudio_pxy.c ip_state.c > > ip_state.h ipl.h > > Log: > > fix conflicts created by import >=20 > Could you describe these "conflicts"? I estimate about 1000 lines of > changes. Last time I looked at a commit like this, it consisted > mainly of bug fixes. It would be nice to know what has been fixed, > especially in a security-related product. That's not what we usually do for vendor imports: this commit is presumably the result of CVS's semi-automatic conflict resolution when you do an import, and the line diff count just shows up because the file is off the vendor branch. It's no different than the diffs which don't conflict and which also change thousands of lines of code: those are just hidden internally by CVS. The changes in the code are presumably described within the changelog file includes in the CVS repository. We don't traditionally summarize the changes (except in some cases for major new features or bugfixes) when doing any vendor import, the reason being the information is available within the repository in the changelog file which is imported. Kris --X1bOJ3K7DJ5YkBrT Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (FreeBSD) Comment: For info see http://www.gnupg.org iD8DBQE7Y9tPWry0BWjoQKURApOTAKDj1JtwHGPoWDNMsrYRdJsTDmNe5wCgnhfs I09/7K+mrGt3zf9HuxEawf8= =TdQe -----END PGP SIGNATURE----- --X1bOJ3K7DJ5YkBrT-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message