From owner-svn-src-head@freebsd.org Wed Sep 23 23:11:12 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 78E413E19D9 for ; Wed, 23 Sep 2020 23:11:12 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qv1-xf2e.google.com (mail-qv1-xf2e.google.com [IPv6:2607:f8b0:4864:20::f2e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BxYnq4rRPz4W35 for ; Wed, 23 Sep 2020 23:11:11 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qv1-xf2e.google.com with SMTP id p15so894427qvk.5 for ; Wed, 23 Sep 2020 16:11:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HVdx5C0mgKFzHQjhScv9yaOag5JUbZ+Di0r1F1Brvho=; b=NdvhbG80oI1jiqBxUTWTJxFz1aKp//baPWE7ROdGlfLEt8epgGne5x3t0MQ7mZjCws quTGYzIOhuKuh552pgmFJpIUrHkTKlom43JdijlfexfZ3XF4Qnd7x+6zd+I67uW+TFYv ozq8lIy4tmk4jQ7SlpQOveYArP3J8C/hEnklpkHJbAxCWtOnYPNHaFq02Eg1R+h/Kt8d fD04swFBQH5GYQqliLw2Dj7qQ4U3ZaHK+6vo5tPd3urrAr5NFfLkrZSzGGWmOwFdhHP2 CCul8fxs3kqOP0RBs9yxLzPzCZd57ZBPBMB0AwEE7j8xi8uOi0bCX8V4vynUGJTZok9P k7cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HVdx5C0mgKFzHQjhScv9yaOag5JUbZ+Di0r1F1Brvho=; b=FepNLTQPbPvf9NmU1I2RRAzXDOyqg1+2g83vCfR0DqJQcTbJ3fgpPsWogsGc9Wb/9w 9mXMxGy1IfKHIifkuehgEZf2X4ts6YPjiM1a9Tn3Qpj+GGLHRXukzseZVimQZilScKxq YZGp4CojjeL2NmcFBrQTCUhh4addrMlFgGS4AH4W3iSwwVW9al9CdodPFNsFNsGH8NZN EI06jRzgljsziV+TmqVEyT9AovWKI8dW/SvzKIeYwNl7qXgHT+hTBXoLuWzWm4KKgVgU CmQQ78kFgAWy6lxIT5iwyUyG3IpqgV8IXgQGs66/gZkX9wodnya3PxYJglQdgnqPQXUd mSEA== X-Gm-Message-State: AOAM533inkcQHRCt2Wd3mbyGX6AIuAk1totgdz1THtj4tfrBoGiS3HFS Dm/zFo5KeMVNMiEhFvZ8A66E6F63D4dOWV5X0t8YVg== X-Google-Smtp-Source: ABdhPJzaVUwX0+ndnxjXjZYHvdyAUmCUdWsmru3kLHjK42lhiJ2JCoKURYTJ0Bydxbh5sAYtcwGQKqKC57GY3V+Lg4Q= X-Received: by 2002:ad4:4a6b:: with SMTP id cn11mr2528103qvb.53.1600902670611; Wed, 23 Sep 2020 16:11:10 -0700 (PDT) MIME-Version: 1.0 References: <202009222301.08MN1rkh076778@repo.freebsd.org> In-Reply-To: From: Warner Losh Date: Wed, 23 Sep 2020 17:10:59 -0600 Message-ID: Subject: Re: svn commit: r366025 - head/share/man/man9 To: xtouqh@hotmail.com Cc: Warner Losh , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 4BxYnq4rRPz4W35 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=NdvhbG80; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::f2e) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-2.36 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; NEURAL_HAM_MEDIUM(-0.95)[-0.952]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-0.92)[-0.920]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; NEURAL_HAM_SHORT(-0.49)[-0.487]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::f2e:from]; R_SPF_NA(0.00)[no SPF record]; FREEMAIL_TO(0.00)[hotmail.com]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; MAILMAN_DEST(0.00)[svn-src-head]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Sep 2020 23:11:12 -0000 On Wed, Sep 23, 2020 at 12:27 PM wrote: > Warner Losh wrote: > > Author: imp > > Date: Tue Sep 22 23:01:53 2020 > > New Revision: 366025 > > URL: https://svnweb.freebsd.org/changeset/base/366025 > > > > Log: > > Document devctl_safe_quote_sb > > > > This routine centralizes the knowledge needed for properly quoting > > 'value' in all key="value" items that appear in devctl messages. > > > > Reviewed by: bcr > > Differential Revision: https://reviews.freebsd.org/D26520 > > > > Added: > > head/share/man/man9/devctl_safe_quote_sb.9 (contents, props changed) > > Modified: > > head/share/man/man9/Makefile > > > > Modified: head/share/man/man9/Makefile > > > ============================================================================== > > --- head/share/man/man9/Makefile Tue Sep 22 23:01:44 2020 > (r366024) > > +++ head/share/man/man9/Makefile Tue Sep 22 23:01:53 2020 > (r366025) > > @@ -122,6 +122,8 @@ MAN= accept_filter.9 \ > > DEV_MODULE.9 \ > > dev_refthread.9 \ > > devctl_process_running.9 \ > > + devctl_safe_quote_sb.9 \ > > + devctl_ > > devstat.9 \ > > devtoname.9 \ > > disk.9 \ > > > > Added: head/share/man/man9/devctl_safe_quote_sb.9 > > > ============================================================================== > > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > > +++ head/share/man/man9/devctl_safe_quote_sb.9 Tue Sep 22 > 23:01:53 2020 (r366025) > > @@ -0,0 +1,57 @@ > > +.\" > > +.\" Copyright (c) 2020 M Warner Losh > > +.\" > > +.\" This program is free software. > > +.\" > > +.\" Redistribution and use in source and binary forms, with or without > > +.\" modification, are permitted provided that the following conditions > > +.\" are met: > > +.\" 1. Redistributions of source code must retain the above copyright > > +.\" notice, this list of conditions and the following disclaimer. > > +.\" 2. Redistributions in binary form must reproduce the above copyright > > +.\" notice, this list of conditions and the following disclaimer in > the > > +.\" documentation and/or other materials provided with the > distribution. > > +.\" > > +.\" THIS SOFTWARE IS PROVIDED BY THE DEVELOPERS ``AS IS'' AND ANY > EXPRESS OR > > +.\" IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED > WARRANTIES > > +.\" OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE > DISCLAIMED. > > +.\" IN NO EVENT SHALL THE DEVELOPERS BE LIABLE FOR ANY DIRECT, INDIRECT, > > +.\" INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES > (INCLUDING, BUT > > +.\" NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS > OF USE, > > +.\" DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON > ANY > > +.\" THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > > +.\" (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE > USE OF > > +.\" THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > +.\" > > +.\" $FreeBSD$ > > +.\" > > +.Dd September 22, 2020 > > +.Dt DEVCTL_SAFE_QUOTE_SB 9 > > +.Os > > +.Sh NAME > > +.Nm devctl_safe_quote_sb > > +.Nd Insert a string, properly quoted, into a sbuf > > +.Sh SYNOPSIS > > +.In sys/devctl.h > > +.In sys/sbuf.h > > +.Ft void > > +.Fn devctl_safe_quote_sb "struct sbuf *sb" "const char *src" > > +.Sh DESCRIPTION > > +Copy the string from > > +.Vn src > > .Va > > > +into > > +.Vn sb . > > .Va > > > +All backslash characters are doubled. > > +All double quote characters > > +.Sq " > > .Sq \&" > fixed. thanks! Warner > > +are also preceded by a backslash. > > +All other characters are copied without modification. > > +The > > +.Xr devctl 4 > > +protocol requires quoted string to be quoted thus. > > +This routine centralizes this knowledge. > > +.Sh SEE ALSO > > +.Xr devd 8 > > +.Sh AUTHORS > > +This manual page was written by > > +.An M. Warner Losh >