From owner-svn-src-user@FreeBSD.ORG Tue Mar 12 12:04:52 2013 Return-Path: <owner-svn-src-user@FreeBSD.ORG> Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 959B2470; Tue, 12 Mar 2013 12:04:52 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-ia0-x22f.google.com (mail-ia0-x22f.google.com [IPv6:2607:f8b0:4001:c02::22f]) by mx1.freebsd.org (Postfix) with ESMTP id 2F3E19E; Tue, 12 Mar 2013 12:04:52 +0000 (UTC) Received: by mail-ia0-f175.google.com with SMTP id y26so629999iab.6 for <multiple recipients>; Tue, 12 Mar 2013 05:04:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:reply-to:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=jVgnnRcZrGk7GysozfmaxVs1URw6c2NOpazR5koDM1c=; b=jtQl9mQOVRua+YrZ27IGhPkOPbGQLcYAhu2i82+VrIdhF+EydKQn733gaxONdMuY8q 6Ed4WiAz2oBtuulAGJqpiqqnTReUg/XWxdvxdbkV20tma1wh3XeZ+EcumYFvrTtGRjfp fkPoGCwwaAkXmaGZ9v8naNkxOtsdlhcfImCOtr8qvvmX6wAByjkYsIOV6WotvVKhIDMo uzJvZCwyl+Uq/x7CHLJxt+8khXIW3DNi+zfuyqqKk/5hvBVmads8Em3yE+jZ2n2eZEZy C0/GlFsvPw+Jt2QGhvWjs9QThP7sccbsCejGXb0OvRydbrSwJHBN+h24B0nb3ZYcwkLe E0ow== MIME-Version: 1.0 X-Received: by 10.50.190.164 with SMTP id gr4mr11260524igc.19.1363089891854; Tue, 12 Mar 2013 05:04:51 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.42.117.134 with HTTP; Tue, 12 Mar 2013 05:04:51 -0700 (PDT) In-Reply-To: <201303120614.r2C6EWve058965@svn.freebsd.org> References: <201303120614.r2C6EWve058965@svn.freebsd.org> Date: Tue, 12 Mar 2013 13:04:51 +0100 X-Google-Sender-Auth: mEp1ilKnYfQI3VcOX69RtTt5psY Message-ID: <CAJ-FndCU5T4K=sLMF0t0vrn_J=nhASgrtGH7+qbeBrZoXr1MmQ@mail.gmail.com> Subject: Re: svn commit: r248185 - user/attilio/vmcontention/sys/vm From: Attilio Rao <attilio@freebsd.org> To: Alan Cox <alc@freebsd.org> Content-Type: text/plain; charset=UTF-8 Cc: src-committers@freebsd.org, svn-src-user@freebsd.org X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: attilio@FreeBSD.org List-Id: "SVN commit messages for the experimental " user" src tree" <svn-src-user.freebsd.org> List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-user>, <mailto:svn-src-user-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/svn-src-user> List-Post: <mailto:svn-src-user@freebsd.org> List-Help: <mailto:svn-src-user-request@freebsd.org?subject=help> List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-user>, <mailto:svn-src-user-request@freebsd.org?subject=subscribe> X-List-Received-Date: Tue, 12 Mar 2013 12:04:52 -0000 On Tue, Mar 12, 2013 at 7:14 AM, Alan Cox <alc@freebsd.org> wrote: > Author: alc > Date: Tue Mar 12 06:14:31 2013 > New Revision: 248185 > URL: http://svnweb.freebsd.org/changeset/base/248185 > > Log: > When transferring the page from one object to another, don't insert the > page into its new object until the page's pindex has been updated. > Otherwise, one code path within vm_radix_insert() may use the wrong > pindex value. This is just a style change really because the code already subtracts offindxstart from current m->pindex when inserting. The pindex on the page is then adjusted when the real subtraction happens. IIRC, I did this way because of less diffs against -CURRENT, but the code looks correct to me already in the older version. Attilio -- Peace can only be achieved by understanding - A. Einstein