From owner-dev-commits-ports-main@freebsd.org Wed May 19 02:33:47 2021 Return-Path: Delivered-To: dev-commits-ports-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 13BBB635782; Wed, 19 May 2021 02:33:47 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FlH4B73S1z4Rfn; Wed, 19 May 2021 02:33:46 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1621391627; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mE9LJ0NOLmHZuEvWwPv1PsArDiP1sxf8BhVl3aS76qM=; b=vHwwb+r3qIuRLdklZGc8943j76F7y769EFgk34YJtg2BsoSkRw+i7Xo31gy9V1UuhT5uM7 MmZBNlRpx29iqvey2XosI8k3q15eRzrn3vp0uhJBiuB389QzLfpp7bqmVBRRChFhZS8vOY 9DlQoq91WAD4AxNB9uToiHuQ2xCAZDL2DYBwCswJ6cE89UKH5twCOtr3MA/BQiSDfcjxjN zlIkOjQQTrYBcfdimWWJbPL74SgzaCY/OFnlZHoxXau/N241FfMyeyp2bpmF2sK+kXlFsS +f5LQ4wk+cPEIABoCJDOKe68RTUWm3aFvicN5WfvdbYlCS2PzUxJ3UrnqnhXcQ== Received: by freefall.freebsd.org (Postfix, from userid 1033) id E2FB41302A; Wed, 19 May 2021 02:33:46 +0000 (UTC) Date: Wed, 19 May 2021 02:33:46 +0000 From: Alexey Dokuchaev To: Joseph Mingrone Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 6464fe05fe9d - main - - Update Unipro UGENE to version 38.1 and thus unbreak - CONFIG defaults to 64-bit mode now, adjust the check Message-ID: References: <202105181525.14IFPYMT003113@gitrepo.freebsd.org> <86pmxo56wi.fsf@phe.ftfl.ca> <868s4b6az4.fsf@phe.ftfl.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <868s4b6az4.fsf@phe.ftfl.ca> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1621391627; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mE9LJ0NOLmHZuEvWwPv1PsArDiP1sxf8BhVl3aS76qM=; b=f3kOtftYVH6AM8FjxXvYBkJqX2vxBHzh1tQceewvaEFN3/RCP2C2l1Wgta5Ef/yg72nFQ6 SgrNXEOBV0fCYFiE6b5PUPJ3mDZCW6ZyWpw9yoRmv34YeOBSx94/ch1zfl/QUDfXKqcOVQ DLE7yalHjfH2fMLIixTIia3W7VIn+SpdJ3EMswhroMXjPQWrljYCG8YYGr4Qx0CKKVovJb XmIiqK3v3pK72PkDRAdbZQ5XsJQXp/4noQhpHH1ckQHY43tPNdjKE051Txu6UmVNls3LrF v62yHUF1n8K+mTfcVj5Ellv2EorVFtV6lUi0rHMzg0HZzZ4nd02XO2/tv6aesw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1621391627; a=rsa-sha256; cv=none; b=cBnbnfi4ZQTGI7P805NnxwAsMcNlmaW/Tk6oV7xYByn+AdWh7kR8OraUal/be7gMryATUh xETDPPLwAa/m7KiHCEsrJGXYgZcZbZtwatcx5zmvqQtFhzaqEnsx+Sb6PfzKIIZ6gc5E4h tBH2quJFy15NfYQvildTwTSfE2Vazab+XWpiwX9nb5pIaN8fkvsDL4G9T0cVW2L/6bGjpG Iupg7QrGPWgpCbIKb6LV9D2KumKAR573IRgWJBFee9eMy0g/MUuYn3oAHn0PoFAJkwsCD5 2NwfqBdqBKzeFFv4PmNquUv0Ro6txHbcuChKyMAdKtNGSsf+HzMCMY260gLRNA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-BeenThere: dev-commits-ports-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commits to the main branch of the FreeBSD ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 May 2021 02:33:47 -0000 On Tue, May 18, 2021 at 05:30:39PM -0300, Joseph Mingrone wrote: > On Tue, 2021-05-18 at 20:09, Alexey Dokuchaev wrote: > ... > > It's a known bug in Git, for some reason it does not stop at first \n. > > Interestingly, cgit web frontend does not exhibit this problem, does > > it use some smarter form of shortlog? > > > The main point, however, is that commit logs should not contain what > > can be easily and automatically inferred from the commit itself. As > > an example of sanity, have a look at https://freshbsd.org/freebsd, > > which infers correct commit headers and clearly shows how needlessly > > noisy those "canonical" logs start to look like if you do things the > > right way. > > The FreshBSD page seems to be showing full commit logs. This is not what I was pointing at. Albeit I find shortlogs utterly useless, one could still infer path (category/port) information from the commit and append the first line of the commit log to it. There is absolutely no need to *manually* put it in the log, this information is *already* embedded in the commit and can be extracted automatically, regardless of the log format. In fact, if you do put it manually, it means it could be wrong, either accidentally or maliciously. If some particular gitish tool does not infer it, then it should be fixed, not commit logs pessimized. > I don't know how cgit implements their log display, but it's not a bug. > It's a convention. Convention (which I don't like) is "short\n\nlong" log format; the bug is that git shortlog does not stop after the first \n, contrary to what the word "short" means. ./danfe