From owner-freebsd-scsi  Tue Feb 19 21:18:27 2002
Delivered-To: freebsd-scsi@freebsd.org
Received: from mail.sat.t.u-tokyo.ac.jp (nat.keisu.t.u-tokyo.ac.jp [133.11.68.2])
	by hub.freebsd.org (Postfix) with ESMTP id 9AA4C37B404
	for <freebsd-scsi@freebsd.org>; Tue, 19 Feb 2002 21:18:22 -0800 (PST)
Received: from ett.sat.t.u-tokyo.ac.jp (ett.sat.t.u-tokyo.ac.jp [10.6.1.30])
	by mail.sat.t.u-tokyo.ac.jp (Postfix) with ESMTP
	id D772C2DABB; Wed, 20 Feb 2002 14:18:21 +0900 (JST)
Date: Wed, 20 Feb 2002 14:18:21 +0900
Message-ID: <ybs1yfgybmq.wl@ett.sat.t.u-tokyo.ac.jp>
From: Hidetoshi Shimokawa <simokawa@sat.t.u-tokyo.ac.jp>
To: freebsd-scsi@freebsd.org
Cc: Katsushi Kobayashi <ikob@koganei.wide.ad.jp>
Subject: RBC support patch
User-Agent: Wanderlust/2.4.1 (Stand By Me) REMI/1.14.3 (Matsudai) FLIM/1.13.2 (Kasanui) APEL/10.3 MULE XEmacs/21.2 (beta19) (Shinjuku) (i386-unknown-freebsd3.2)
X-Face: OE([KxWyJI0r[R~S/>7ia}SJ)i%a,$-9%7{*yihQk|]gl}2p#"oXmX/fT}Bn7:#j7i14gu$
 jgR\S*&C3R/pJX<mI-4Z8'mqt1R'CjWdw-xqVoilv`\JgZcquM5oVuO^<vt/~051rCDM(`{rM~?{Ok
 r,XC+}Ycm9IJO)odT*-0nyJjBJYzL{GsZ
MIME-Version: 1.0 (generated by REMI 1.14.3 - "Matsudai")
Content-Type: text/plain; charset=US-ASCII
Sender: owner-freebsd-scsi@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-scsi.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-scsi>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-scsi>
X-Loop: FreeBSD.org

I'm developing firewire/SBP driver with kobayashi-san and
We need RBC support in SCSI layer.

Here is a patch for RBC.
Can I commit this to current or could someone commit?

Another issue, there are many broken 'Direct Access' devices which
don't support 'READ(6)/WRITE(6)' operations.
You can see tons of quirks in scsi_da.c for that.

Why don't we set minimum_cmd_size as 10 by default?
Old drivers doesn't have READ(10)/WRITE(10) ?

/\ Hidetoshi Shimokawa
\/  simokawa@sat.t.u-tokyo.ac.jp
PGP public key: http://www.sat.t.u-tokyo.ac.jp/~simokawa/pgp.html


Index: scsi/scsi_all.c
===================================================================
RCS file: /home/ncvs/src/sys/cam/scsi/scsi_all.c,v
retrieving revision 1.28
diff -u -r1.28 scsi_all.c
--- scsi/scsi_all.c	6 Nov 2001 23:50:33 -0000	1.28
+++ scsi/scsi_all.c	18 Feb 2002 13:13:56 -0000
@@ -2220,6 +2220,12 @@
 	case T_ENCLOSURE:
 		dtype = "Enclosure Services";
 		break;
+	case T_RBC:
+		dtype = "Simplified Direct Access";
+		break;
+	case T_OCRW:
+		dtype = "Optical Card Read/Write";
+		break;
 	case T_NODEVICE:
 		dtype = "Uninstalled";
 	default:
Index: scsi/scsi_da.c
===================================================================
RCS file: /home/ncvs/src/sys/cam/scsi/scsi_da.c,v
retrieving revision 1.96
diff -u -r1.96 scsi_da.c
--- scsi/scsi_da.c	31 Jan 2002 11:39:16 -0000	1.96
+++ scsi/scsi_da.c	18 Feb 2002 13:51:49 -0000
@@ -1025,6 +1039,7 @@
 			break;
 
 		if (SID_TYPE(&cgd->inq_data) != T_DIRECT
+		    && SID_TYPE(&cgd->inq_data) != T_RBC
 		    && SID_TYPE(&cgd->inq_data) != T_OPTICAL)
 			break;
 
@@ -1124,7 +1139,7 @@
 	else
 		softc->quirks = DA_Q_NONE;
 
-	if (softc->quirks & DA_Q_NO_6_BYTE)
+	if (softc->quirks & DA_Q_NO_6_BYTE || SID_TYPE(&cgd->inq_data) == T_RBC)
 		softc->minimum_cmd_size = 10;
 	else
 		softc->minimum_cmd_size = 6;


/\ Hidetoshi Shimokawa
\/  simokawa@sat.t.u-tokyo.ac.jp
PGP public key: http://www.sat.t.u-tokyo.ac.jp/~simokawa/pgp.html

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-scsi" in the body of the message