Date: Wed, 20 Feb 2002 14:18:21 +0900 From: Hidetoshi Shimokawa <simokawa@sat.t.u-tokyo.ac.jp> To: freebsd-scsi@freebsd.org Cc: Katsushi Kobayashi <ikob@koganei.wide.ad.jp> Subject: RBC support patch Message-ID: <ybs1yfgybmq.wl@ett.sat.t.u-tokyo.ac.jp>
next in thread | raw e-mail | index | archive | help
I'm developing firewire/SBP driver with kobayashi-san and We need RBC support in SCSI layer. Here is a patch for RBC. Can I commit this to current or could someone commit? Another issue, there are many broken 'Direct Access' devices which don't support 'READ(6)/WRITE(6)' operations. You can see tons of quirks in scsi_da.c for that. Why don't we set minimum_cmd_size as 10 by default? Old drivers doesn't have READ(10)/WRITE(10) ? /\ Hidetoshi Shimokawa \/ simokawa@sat.t.u-tokyo.ac.jp PGP public key: http://www.sat.t.u-tokyo.ac.jp/~simokawa/pgp.html Index: scsi/scsi_all.c =================================================================== RCS file: /home/ncvs/src/sys/cam/scsi/scsi_all.c,v retrieving revision 1.28 diff -u -r1.28 scsi_all.c --- scsi/scsi_all.c 6 Nov 2001 23:50:33 -0000 1.28 +++ scsi/scsi_all.c 18 Feb 2002 13:13:56 -0000 @@ -2220,6 +2220,12 @@ case T_ENCLOSURE: dtype = "Enclosure Services"; break; + case T_RBC: + dtype = "Simplified Direct Access"; + break; + case T_OCRW: + dtype = "Optical Card Read/Write"; + break; case T_NODEVICE: dtype = "Uninstalled"; default: Index: scsi/scsi_da.c =================================================================== RCS file: /home/ncvs/src/sys/cam/scsi/scsi_da.c,v retrieving revision 1.96 diff -u -r1.96 scsi_da.c --- scsi/scsi_da.c 31 Jan 2002 11:39:16 -0000 1.96 +++ scsi/scsi_da.c 18 Feb 2002 13:51:49 -0000 @@ -1025,6 +1039,7 @@ break; if (SID_TYPE(&cgd->inq_data) != T_DIRECT + && SID_TYPE(&cgd->inq_data) != T_RBC && SID_TYPE(&cgd->inq_data) != T_OPTICAL) break; @@ -1124,7 +1139,7 @@ else softc->quirks = DA_Q_NONE; - if (softc->quirks & DA_Q_NO_6_BYTE) + if (softc->quirks & DA_Q_NO_6_BYTE || SID_TYPE(&cgd->inq_data) == T_RBC) softc->minimum_cmd_size = 10; else softc->minimum_cmd_size = 6; /\ Hidetoshi Shimokawa \/ simokawa@sat.t.u-tokyo.ac.jp PGP public key: http://www.sat.t.u-tokyo.ac.jp/~simokawa/pgp.html To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-scsi" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ybs1yfgybmq.wl>