From owner-freebsd-ports@FreeBSD.ORG Mon Aug 20 18:51:44 2012 Return-Path: Delivered-To: freebsd-ports@FreeBSD.org Received: from mx2.freebsd.org (mx2.freebsd.org [69.147.83.53]) by hub.freebsd.org (Postfix) with ESMTP id 5E021106564A; Mon, 20 Aug 2012 18:51:44 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from opti.dougb.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 6B8E814DA62; Mon, 20 Aug 2012 18:51:43 +0000 (UTC) Message-ID: <5032873F.3090108@FreeBSD.org> Date: Mon, 20 Aug 2012 11:51:43 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:14.0) Gecko/20120728 Thunderbird/14.0 MIME-Version: 1.0 To: George Neville-Neil References: <86hatodavd.wl%gnn@neville-neil.com> <1341340703.6639@da3m0n8t3r.com> <20120704194917.GA15426@misty.eyesbeyond.com> <2244ACD7-892A-4CA7-90B1-FFF41AF6B317@FreeBSD.org> <49BAAAB5-BF68-43B3-8D7C-B4E49DE29ED3@neville-neil.com> <4FFA4454.5070803@FreeBSD.org> <4FFA5AF0.607@FreeBSD.org> <8DB0856C-A5D6-4C03-9246-743E51BC8B86@freebsd.org> <501F6C8E.3030008@FreeBSD.org> In-Reply-To: X-Enigmail-Version: 1.4.3 OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: skreuzer@FreeBSD.org, freebsd-ports@FreeBSD.org Subject: Re: devel/zookeeper rc.d script X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Aug 2012 18:51:44 -0000 On 08/20/2012 08:43, George Neville-Neil wrote: > > On Aug 6, 2012, at 03:04 , Doug Barton wrote: > >> On 07/09/2012 08:57, George Neville-Neil wrote: >>> >>> On Jul 9, 2012, at 00:15 , Doug Barton wrote: >>> >>>> On 07/08/2012 20:01, George Neville-Neil wrote: >>>>> >>>>> On Jul 8, 2012, at 22:39 , Doug Barton wrote: >>>>> >>>>>> On 07/08/2012 19:33, George Neville-Neil wrote: >>>>>>> A followup. zookeeper is now ported to Freebsd (/usr/ports/devel/zookeeper) >>>>>> >>>>>> George, did you see the PR and the followup from me regarding the port? >>>>>> >>>>> >>>>> I got a mail from jgh@ but only today figured out what the PR was. >>>> >>>> Are you not getting your gnn@FreeBSD.org mail? >>>> >>>>> I'll look at the patches from him tomorrow. >>>> >>>> I copied the text from my message below for your convenience. >>>> >>>>> http://www.freebsd.org/cgi/query-pr.cgi?pr=169693 >>>> >>>> Furthermore the rc.d script is a mess, and should not have been >>>> committed like it was (numerous missing bits, bad format, set_rcvar, >>>> hard-coded /usr/local, no REQUIRE, no KEYWORD: shutdown, etc.). Please >>>> read >>>> http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html >>>> and then ask in freebsd-rc@ if you have any additional questions. Sorry >>>> to be so blunt, but I'm really, really tired of repeating the same stuff >>>> over and over again, and this script is really a mess. >>>> >>>> Also, don't install the script in do-install, see the web page above >>>> (and/or the PR) for USE_RC_SUBR. >>>> >>>> And FYI, there is no need to have the function in that script. You could >>>> use (for example) start_cmd="$command start" just as well. Not to >>>> mention that the function you have should be using $1 as the argument to >>>> $command, not $rc_arg. Reasons why left as an exercise for the reader ... >> >> George, >> >> Some of these issues were covered by the PR, but many of them were not. >> If you have any questions about the changes that are needed you should >> feel free to ask on freebsd-rc@FreeBSD.org. >> > > I think many or most of these are addressed by updates being made by > Steven Kreuzer to both this port and the zookeeper-devel port. Thanks! Steven, if you have any questions, feel free to shoot them over to freebsd-rc@. -- I am only one, but I am one. I cannot do everything, but I can do something. And I will not let what I cannot do interfere with what I can do. -- Edward Everett Hale, (1822 - 1909)