From owner-freebsd-scsi@FreeBSD.ORG Sun Oct 29 05:30:46 2006 Return-Path: X-Original-To: freebsd-scsi@freebsd.org Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D510816A407 for ; Sun, 29 Oct 2006 05:30:46 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6D56C43D49 for ; Sun, 29 Oct 2006 05:30:46 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.254.11] (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id k9T5Udms025717; Sat, 28 Oct 2006 23:30:45 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <45443C7F.5040508@samsco.org> Date: Sat, 28 Oct 2006 23:30:39 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.0.7) Gecko/20060910 SeaMonkey/1.0.5 MIME-Version: 1.0 To: Matthew Jacob References: <7579f7fb0610281854l3ec600d7kf0a2cdf20fdcb838@mail.gmail.com> <7579f7fb0610282210p59de2123g379f0d4069bd1e42@mail.gmail.com> In-Reply-To: <7579f7fb0610282210p59de2123g379f0d4069bd1e42@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.1.1 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org Cc: freebsd-scsi@freebsd.org Subject: Re: CAM_NEW_TRAN- kernel changes ready for review X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Oct 2006 05:30:46 -0000 Matthew Jacob wrote: > This has been updated after I found I'd forgotten to fill in a couple > of items (*cough*). > 1) I thought that you were just going to push forward and make NEW_TRAN be the de-facto. Why bother keeping the #ifdefs? If I misunderstood, I apologize. 2) Does the protocol_version field in the cts and cpi refer to the SCSI protocol (i.e. SCSI-1/2/3, etc)? If so, isn't that more of a per-device quality, not a per-sim quality? Hard-coding it in the SIM for all devices would then seem wrong, shouldn't CAM get it out of the INQ data? 3) For atapi-cam, I think that the cts->protocol should still be PROTO_SCSI, not PROTO_ATA. Having cpi->transport by XPORT_SPI also seems wrong, as IDE is fairly different from SPI, and I'd like at some point to have a real IDE/SATA transport that understands the differences. For that matter, it might also be useful to differentiate between PROTO_SCSI and say PROTO_RBC or PROTO_ATAPI or PROTO_MMC. Might make dealing with USB and firewire easier than the quirky mess that is there now. Otherwise, looks pretty good. If you want to push forward and commit, I can help clean up any goofs or missed drivers. Scott