From nobody Thu Feb 26 14:33:52 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fMDVG4Cw7z6SYLc for ; Thu, 26 Feb 2026 14:33:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fMDVG1LPwz3HGK for ; Thu, 26 Feb 2026 14:33:58 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1772116438; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=w0lark9dn2zS6C/LmhLiwjvjoi7XL33O8mknRjib6fc=; b=yC/Sk3+W6iPGOUShFwIXcqI3uI4xJ51Z0mG/IJ9+yZbIYK84DdDJg1I9biQpqN6s5msz8j q5MCzMBL2Yfmm4QcIQGw4oVX4ZLuwoOP41/kgRKz1QzItZnvo4iciIC6R9+IzJoxC3yh+9 gC4jWABC8a55ppBa09WKNmt+LiEJ4MTSfqdMRswzx5+YFFCfsBbZMHV+jyyRzcCm7tOZRu 8G/xcJWtDc501h8IeR9KudKUvliQdsqnXxbn0Gnj0+wBdBcGUT5c5OStlBE8LaAOSA/fEH 3G5ET9G1yiCdBy+FX22ZVorNmyZ7QqY0W1OGTy/FH0UkYwul9PlE435M7pFkaw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1772116438; a=rsa-sha256; cv=none; b=vQNbsyVgzQGy4lYsKI85/UZoedY5sCAe7A0kmvc9ypKQKhYf0kjEY9hVlgrxG2Lj7D/wCk Zd1DQrREzlAsS2a5VMp+MKGHX9U4tFkLMOks4IL7xjpnPQKaIFwOcvZwIsqZAPUtkLzrwR YjEuweD56ij/TUeINVgrXH/QxNilZwic28K2eP1EtW5oxKKZztduWKBVFIoYIBJYJrpbI8 O1OU7ZDF6uQnvzanY/+FaL7w3H0SnQbklSELQNnP4lcCbCG70ZQd6l9UvPickhDk2eZe6w MgIiJoe6wTVYDUFI1vHKbkwBS6y7lHEwmNeetB6aHw9vqeThZxEwQwQrRxBgLg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1772116438; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=w0lark9dn2zS6C/LmhLiwjvjoi7XL33O8mknRjib6fc=; b=GIEijI6wewq+ZsXfEEYL1PfpPv2mMsFvoySxuwIk/RjjpZ+c0YZhvY078kWOdtnQ7XRfXJ Q3qaBW97IQaSK7HMfxaw043d+g0vW/t6Fpo8WSjENB8FWBOEL48Yt18lkGC3L943Y1zG4k vNJR8A0T9eF4qAb3W0S2LE66mRccV6H4olSif3gAq1e+Xiq24TEoIQu2ph3S4l3/QsI22q ztFOCnAeKhCTRa/wbsYbppRMMaroyGJ6eqQ7RPfa1oPgY6UcICuV5sWe0xfOyZ6U20Tj4/ /dEaC/zhAT22pc66D0f/jUL9FEk/klDxLLPmCoqEtoP/MIah4NjW/qkaLV358Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fMDVG0vlXzcNm for ; Thu, 26 Feb 2026 14:33:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 26920 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 26 Feb 2026 14:33:52 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Kristof Provost From: Zhenlei Huang Subject: git: baed1f130ab1 - stable/13 - qlnx: fix panic at startup List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: zlei X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: baed1f130ab1ca0e553f2cb031f3cfd040ba3cfb Auto-Submitted: auto-generated Date: Thu, 26 Feb 2026 14:33:52 +0000 Message-Id: <69a059d0.26920.4c001e4@gitrepo.freebsd.org> The branch stable/13 has been updated by zlei: URL: https://cgit.FreeBSD.org/src/commit/?id=baed1f130ab1ca0e553f2cb031f3cfd040ba3cfb commit baed1f130ab1ca0e553f2cb031f3cfd040ba3cfb Author: Kristof Provost AuthorDate: 2025-06-12 16:53:33 +0000 Commit: Zhenlei Huang CommitDate: 2026-02-26 14:17:22 +0000 qlnx: fix panic at startup While attaching the qlnx driver we can end up trying to call ifmedia functions before those are set up (through ether_ifattach() -> rtnl_handle_ifattach() -> dump_iface() -> get_operstate_ether() -> ifmedia_ioctl()). Postpone the ether_ifattach() until after the ifmedia setup. Reviewed by: markj,zlei Sponsored by: Rubicon Communications, LLC ("Netgate") Differential Revision: https://reviews.freebsd.org/D50819 MFC note: qlnxe(4) does not exhibit panic at startup on stable/13, but there's a small windows that the setup of ifmedia has not been done but other threads try to access the ifmedia, since the ifnet is public visible on ether_ifattach(). Postpone ether_ifattach() until after the ifmedia setup to prevent that. (cherry picked from commit 4f7473d18a62077a218ac00817bae09a95b8cbcb) (cherry picked from commit 8ef7ad95e9156bea689274c9d57fc961b203efe2) --- sys/dev/qlnx/qlnxe/qlnx_os.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sys/dev/qlnx/qlnxe/qlnx_os.c b/sys/dev/qlnx/qlnxe/qlnx_os.c index 96a5e9e7e269..2586539617dd 100644 --- a/sys/dev/qlnx/qlnxe/qlnx_os.c +++ b/sys/dev/qlnx/qlnxe/qlnx_os.c @@ -2387,9 +2387,6 @@ qlnx_init_ifnet(device_t dev, qlnx_host_t *ha) ha->primary_mac[5] = (rnd >> 16) & 0xFF; } - ether_ifattach(ifp, ha->primary_mac); - bcopy(IF_LLADDR(ha->ifp), ha->primary_mac, ETHER_ADDR_LEN); - ifp->if_capabilities = IFCAP_HWCSUM; ifp->if_capabilities |= IFCAP_JUMBO_MTU; @@ -2442,6 +2439,9 @@ qlnx_init_ifnet(device_t dev, qlnx_host_t *ha) ifmedia_set(&ha->media, (IFM_ETHER | IFM_AUTO)); + ether_ifattach(ifp, ha->primary_mac); + bcopy(IF_LLADDR(ha->ifp), ha->primary_mac, ETHER_ADDR_LEN); + QL_DPRINT2(ha, "exit\n"); return;