From nobody Tue Jun 23 20:57:10 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4glHSR0ZHvz6j6gG for ; Tue, 23 Jun 2026 20:57:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4glHSQ4qtkz3Jtm for ; Tue, 23 Jun 2026 20:57:10 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782248230; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GGuccEvkigz/H+C8hRF7hrprqNo7cG2n1cYdDE/NNYk=; b=ZQakUDHA5LMDfdnAnU+FJLkeP8wdCCsJC9c2nTlZy9Fpw0ipP/6QZRusImhxXOyZv2W2le 9lDKRxewta21Rqx8yMKiVe7Lj4cgE081X8j2Zvw4KnVX8YmKwMhsZ4Tqcak5hv7c01ADNy CjsdnjH/GornTOn1wiHXIBvmoFD3yvk/aG51N0iwXghXOVo5C1m2dg+dF7NucGoLFE0N5q kvBVfb5ouaY3L4L+pK2SvS96/RO5F95XhGL3Inx0Iohz4e4hOjzyIiEE2sdaNPpWt2yuJd /0iiVwccOyYqaixj3pTL6oayGNBAow8felxbvVgD4NdsofHUGwQKQ58WoFF9vQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1782248230; a=rsa-sha256; cv=none; b=iWXaHy1R+TMwb3CKCccIhYmNLXxnqHEdyvRzs03M+F8GuocSK6lpC+2FSR8Q9gUHhC0tkN tYRSTgvi/wrvnS/k2y7av/eqV2GZvxrYpATS5FgA9NSBhgrWBGA1WC4zZr4wElgTDqH5fI kAEcyINhMomfD7EzSEK7hQibe8ca9Z6YaUjBjeAAnudaABMDfvA8Thp+2xQPWOOniOeftB MDaYKTNo4ly6xBBEwUg5cfwzTsEh1o1ZkYTB2xDkywYwZsQwfqd6Qg5W7p9WHsRBCJDZwF 7+SlWsMfouvvaHeTqAL66/yz64rMa4bV3BdGCdBnmFhw+9S0czIvwxF/Wbvybg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782248230; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GGuccEvkigz/H+C8hRF7hrprqNo7cG2n1cYdDE/NNYk=; b=DTZ/GlsGEUqAta74DB17iSGMhDqG9aaJS7Td2PEMdBu86GAzs2pFOLtn02ltohT/KoW8L/ 5b3vrgGEpCZF9cMNpx1M844pnlzvl451ANhF8NSxI65A9d1cOtp7a5AIqQU98J2npISVLm PW4CsgXqbY3DS0/DB4EBz7Xugb5ZueaT5kpKipG/1O7Ipl0ngA95As0TXn5odDwMeiLWVB /FLVn0yo6Oi2Zdqv6Gl0Jo/eyX7HPIu3KFu5B8vMjuuMasfgsJ44Lqo+2jAJymCJLE86IV g4Yu7BKVNRLhItc+YFuTXLAjTEsEkIECODw0Bjhvl/vwV82taTgdBr8tBF6VnQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4glHSQ3k6JzqTK for ; Tue, 23 Jun 2026 20:57:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1c37f by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 23 Jun 2026 20:57:10 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: ShengYi Hung Subject: git: e01b5034a627 - stable/14 - usb: Add missing mtx lock and unlock in pushing dma queue List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: aokblast X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: e01b5034a627cec33c0cd2768687c7db6db3cbeb Auto-Submitted: auto-generated Date: Tue, 23 Jun 2026 20:57:10 +0000 Message-Id: <6a3af326.1c37f.280ee49@gitrepo.freebsd.org> The branch stable/14 has been updated by aokblast: URL: https://cgit.FreeBSD.org/src/commit/?id=e01b5034a627cec33c0cd2768687c7db6db3cbeb commit e01b5034a627cec33c0cd2768687c7db6db3cbeb Author: ShengYi Hung AuthorDate: 2026-05-28 08:42:11 +0000 Commit: ShengYi Hung CommitDate: 2026-06-23 20:56:03 +0000 usb: Add missing mtx lock and unlock in pushing dma queue Accessing usb_xfer_queue requires bus lock, we added this missing lock in here to prevent racing issue. Reviewed by: adrian MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D57293 (cherry picked from commit df5e9e3da5b9b3fe63ed4aaaa19b824fd18ae0f2) --- sys/dev/usb/usb_transfer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/dev/usb/usb_transfer.c b/sys/dev/usb/usb_transfer.c index 67745cf49397..d41121ed3a06 100644 --- a/sys/dev/usb/usb_transfer.c +++ b/sys/dev/usb/usb_transfer.c @@ -1889,8 +1889,10 @@ usbd_transfer_submit(struct usb_xfer *xfer) */ #if USB_HAVE_BUSDMA if (xfer->flags_int.bdma_enable) { + USB_BUS_LOCK(bus); /* insert the USB transfer last in the BUS-DMA queue */ usb_command_wrapper(&xfer->xroot->dma_q, xfer); + USB_BUS_UNLOCK(bus); return; } #endif