From nobody Thu Sep 7 01:46:59 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Rh2D64pMWz4sGd2 for ; Thu, 7 Sep 2023 01:47:02 +0000 (UTC) (envelope-from cperciva@freebsd.org) Received: from mail.tarsnap.com (mail.tarsnap.com [54.86.246.204]) by mx1.freebsd.org (Postfix) with SMTP id 4Rh2D56P0tz3Q6J for ; Thu, 7 Sep 2023 01:47:01 +0000 (UTC) (envelope-from cperciva@freebsd.org) Authentication-Results: mx1.freebsd.org; none Received: (qmail 55916 invoked from network); 7 Sep 2023 01:46:59 -0000 Received: from unknown (HELO dell7390.daemonology.net) (127.0.0.1) by mail.tarsnap.com with SMTP; 7 Sep 2023 01:46:59 -0000 Received: (qmail 494 invoked from network); 7 Sep 2023 01:46:59 -0000 Received: from unknown (HELO ?127.0.0.1?) (127.0.0.1) by localhost with SMTP; 7 Sep 2023 01:46:59 -0000 Message-ID: Date: Wed, 6 Sep 2023 18:46:59 -0700 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: git: 1926d5cef6ea - main - init_main: Record completed SYSINITs Content-Language: en-US To: Zhenlei Huang Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" References: <202309061837.386Ib5AK086264@gitrepo.freebsd.org> <5BC96D9F-E4C4-4D34-B7B3-41576AD296DA@FreeBSD.org> From: Colin Percival In-Reply-To: <5BC96D9F-E4C4-4D34-B7B3-41576AD296DA@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:14618, ipnet:54.86.0.0/16, country:US] X-Rspamd-Queue-Id: 4Rh2D56P0tz3Q6J On 9/6/23 18:12, Zhenlei Huang wrote: >> On Sep 7, 2023, at 2:37 AM, Colin Percival wrote: >> init_main: Record completed SYSINITs >> >> When removing them from sysinit_list, append them to sysinit_done_list; >> print this list from 'show sysinit' along with the list of future >> sysinits. > > So the `sysinit_done_list` is for DDB only. Well... sort of. You can open up kgdb and run 'p sysinit_done_list'. >> static STAILQ_HEAD(sysinitlist, sysinit) sysinit_list; >> +static struct sysinitlist sysinit_done_list = >> + STAILQ_HEAD_INITIALIZER(sysinit_done_list); > > Then it should be wrapped around with #ifdef DDB and #endif I considered that, but since we're literally talking about 2 pointers of memory I figured it wasn't worth making it conditional. -- Colin Percival FreeBSD Deputy Release Engineer & EC2 platform maintainer Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid