From owner-cvs-all Wed May 29 23:40:26 2002 Delivered-To: cvs-all@freebsd.org Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by hub.freebsd.org (Postfix) with ESMTP id 3212237B404; Wed, 29 May 2002 23:39:43 -0700 (PDT) Received: by elvis.mu.org (Postfix, from userid 1192) id 0F10BAE216; Wed, 29 May 2002 23:39:43 -0700 (PDT) Date: Wed, 29 May 2002 23:39:43 -0700 From: Alfred Perlstein To: "David E. O'Brien" Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/contrib/gcc/config/i386 i386.h Message-ID: <20020530063943.GJ17045@elvis.mu.org> References: <200205300604.g4U64EL88242@freefall.freebsd.org> <20020530063526.GI17045@elvis.mu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020530063526.GI17045@elvis.mu.org> User-Agent: Mutt/1.3.27i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * Alfred Perlstein [020529 23:35] wrote: > * David E. O'Brien [020529 23:04] wrote: > > obrien 2002/05/29 23:04:14 PDT > > > > Modified files: > > contrib/gcc/config/i386 i386.h > > Log: > > Seems we are not ready for revision 1.8. > > Put it back. :) > > It's just bugs because we have: > #ifdef i386 > instead of: > #ifdef __i386__ > > If that's it I'll have it cleaned up in a couple of minutes. > > Notably libc/gmon and gzip. Also I don't see the point of being so damn vague with your commits to the source tree. "Make our default predefines ANSI clean." could have easily been augmented with: "By removing i386 when doing normal compliations" Since parsing the actual delta: - "-Acpu=i386 -Amachine=i386 %{!ansi:%{!std=c*:%{!std=i*:-Di386}}} -D__i386 \ --D__i386__ %(cpp_cpu32sizet)" + "-Acpu=i386 -Amachine=i386 -D__i386 -D__i386__ %(cpp_cpu32sizet)" Doesn't mean much to anyone who hasn't been up to his ears in the gcc source for the last 5 years. :P You do want help right? -- -Alfred Perlstein [alfred@freebsd.org] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.' Tax deductible donations for FreeBSD: http://www.freebsdfoundation.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message