From owner-svn-src-head@FreeBSD.ORG Fri Feb 13 19:11:16 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CC230A98 for ; Fri, 13 Feb 2015 19:11:16 +0000 (UTC) Received: from relay00.pair.com (relay00.pair.com [209.68.5.9]) by mx1.freebsd.org (Postfix) with SMTP id 7DDEACC8 for ; Fri, 13 Feb 2015 19:11:16 +0000 (UTC) Received: (qmail 78425 invoked from network); 13 Feb 2015 19:11:08 -0000 Received: from 188.182.139.176 (HELO x2.osted.lan) (188.182.139.176) by relay00.pair.com with SMTP; 13 Feb 2015 19:11:08 -0000 X-pair-Authenticated: 188.182.139.176 Received: from x2.osted.lan (localhost [127.0.0.1]) by x2.osted.lan (8.14.9/8.14.9) with ESMTP id t1DJB7vw031266 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 13 Feb 2015 20:11:07 +0100 (CET) (envelope-from pho@x2.osted.lan) Received: (from pho@localhost) by x2.osted.lan (8.14.9/8.14.9/Submit) id t1DJB65f031265; Fri, 13 Feb 2015 20:11:06 +0100 (CET) (envelope-from pho) Date: Fri, 13 Feb 2015 20:11:06 +0100 From: Peter Holm To: hiren panchasara Subject: Re: svn commit: r278623 - head/sys/kern Message-ID: <20150213191106.GA30783@x2.osted.lan> References: <201502121331.t1CDV9jR086269@svn.freebsd.org> <20150213182901.GC19044@strugglingcoder.info> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150213182901.GC19044@strugglingcoder.info> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-src-head@freebsd.org, Randall Stewart , svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Feb 2015 19:11:16 -0000 On Fri, Feb 13, 2015 at 10:29:01AM -0800, hiren panchasara wrote: > On 02/12/15 at 01:31P, Randall Stewart wrote: > > Author: rrs > > Date: Thu Feb 12 13:31:08 2015 > > New Revision: 278623 > > URL: https://svnweb.freebsd.org/changeset/base/278623 > > > > Log: > > This fixes a bug I in-advertantly inserted when I updated the callout > > code in my last commit. The cc_exec_next is used to track the next > > when a direct call is being made from callout. It is *never* used > > in the in-direct method. When macro-izing I made it so that it > > would separate out direct/vs/non-direct. This is incorrect and can > > cause panics as Peter Holm has found for me (Thanks so much Peter for > > all your help in this). What this change does is restore that behavior > > but also get rid of the cc_next from the array and instead make it > > be part of the base callout structure. This way no one else will get > > confused since we will never use it for non-direct. > > > > Reviewed by: Peter Holm and more importantly tested by him ;-) > > MFC after: 3 days. > > Sponsored by: Netflix Inc. > > Can I get more info/backtraces for the panic, please? > Sure. These two panics were seen: http://people.freebsd.org/~pho/stress/log/rrs004.txt http://people.freebsd.org/~pho/stress/log/rrs005.txt - Peter