From owner-freebsd-current@freebsd.org Thu Nov 19 15:04:40 2015 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A43BBA32D06 for ; Thu, 19 Nov 2015 15:04:40 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: from mail-io0-x22b.google.com (mail-io0-x22b.google.com [IPv6:2607:f8b0:4001:c06::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6206F1259 for ; Thu, 19 Nov 2015 15:04:40 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: by ioir85 with SMTP id r85so91623141ioi.1 for ; Thu, 19 Nov 2015 07:04:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=BjlRMw6ml3kVoFhCvVfqA/x10gHMmDVfqC5eydzYbh8=; b=KVibywDeg2KRlwZuZJm5ZTffd7Ix9R2LgdFi4PoWxmnMG8rZWfIbKOwix2iCyPj+vr LkoLZOZk+rafigq7R2RZEH5AUqwFvrIXm+QLHs074s743DPI109bEa4/5E2clBIr0RNe Hup+hA16o2AE4ooPOaEQutGJZTaZ3gjRgoKNdYzgInDt+lT0KvCAhg4/rMWBlY25iu4F pvoe5G0jhMSoxc005s0H0YOT8iCMoxK9N+nrVgzmvk/kjkaFcvgtKOCYbx83gyEHlRBt s++F7xWiZwSQtbDHB5KPrts3ZAAnBYuHXtlra0Q9p5y20WMgOYJJ04tJRDhWjEVxHFVi tUpA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alumni-cwru-edu.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=BjlRMw6ml3kVoFhCvVfqA/x10gHMmDVfqC5eydzYbh8=; b=FR5JWD2O/cL5Oc/Ok8ppjc6ozgDSPQSCsx3jj3G1EOLqAc92kk9gtcjCGgXfEfbVsG rfnKMJdWaCYy25KSpddNHM9QSOvjL5hri5BnSb4x3oJGykMzXb9QJ2gOPheYdrh7TePB zR2IpDOQPJI0UPLjpXb7meLhVrzwqzbIhDmNrxXOk6E7vUTJA5at0485VVv/xeQI7KRo 9/1UcllFWBhAPoJotWnEDaDd8ao4plUIkOnFQJAdRVrqpMV5+4Rhxx0Ow5ESHBJhKf8E bzg8qFOtrRV2xjna+17R4NhM7giW0gcqz8dAL+ONtvhsZCadBvTRP8eL8ymdeWFQoaCQ XgOw== MIME-Version: 1.0 X-Received: by 10.107.4.70 with SMTP id 67mr9039477ioe.13.1447945479435; Thu, 19 Nov 2015 07:04:39 -0800 (PST) Sender: chmeeedalf@gmail.com Received: by 10.36.222.198 with HTTP; Thu, 19 Nov 2015 07:04:39 -0800 (PST) In-Reply-To: <78FDD0DE-5CA0-44AB-B46C-9C95E4F8DA5B@rdsor.ro> References: <22918FB9-4DC2-438D-B9F0-C295DD273B50@rdsor.ro> <564DD241.9020801@digiware.nl> <564DD856.6030007@digiware.nl> <78FDD0DE-5CA0-44AB-B46C-9C95E4F8DA5B@rdsor.ro> Date: Thu, 19 Nov 2015 09:04:39 -0600 X-Google-Sender-Auth: zhJeLm0Mlc6bK29wQw_SjQVeyLQ Message-ID: Subject: Re: DDB patches From: Justin Hibbits To: Dan Partelly Cc: Willem Jan Withagen , freebsd-current Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Nov 2015 15:04:40 -0000 On Thu, Nov 19, 2015 at 8:29 AM, Dan Partelly wrote= : >> Unlike what you suggest here, I see lots of issues in Bugzilla which >> exactly what you describe: enhancements on already available tools. >> I've even submitted a few myself. > > Thats great Willem. > > But no matter what you find odd or not, I am simply following what Ive re= ad on some > page on freebsd.org that one of the ways of contributing is by submitting= code > on the mailing-lists , where =E2=80=9Csomebody will happily pick up chang= es=E2=80=9D. > > So, if you continue to find this odd, please take it up with the web-mast= ers on > freebsd.org to update the resources regarding contributing to the project= . Dan, I think a lot of people tend to use the 'one-two punch' of both PR and mailing list. Mailing list to flesh it out and discuss the idea, and the PR when it's ready to go in. I've done a very cursory review of your patch, and it looks pretty good. Unfortunately, my time is booked for more projects than I really have time for, so I'd be unable to test it. If you submit it as a PR in bugzilla, at the very least the patch won't get lost when someone else comes looking for the feature, and more likely it'll get picked up by someone rather quickly or in the next triage phase (some people like to do bug triaging periodically, where things like this get their basic testing and commit). When you said it's not a patch for an issue/bug/etc, one could say the bug is that the patch isn't already in the tree :) . - Justin