From owner-svn-src-head@freebsd.org Fri Apr 7 17:59:48 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5A898D325C1; Fri, 7 Apr 2017 17:59:48 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg0-x229.google.com (mail-pg0-x229.google.com [IPv6:2607:f8b0:400e:c05::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 25F227EB; Fri, 7 Apr 2017 17:59:48 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg0-x229.google.com with SMTP id x125so73261501pgb.0; Fri, 07 Apr 2017 10:59:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=sMnqkOMIhH/QsYn8n3PmQhFB8nSV+DDKJs7BsxontKM=; b=e9t0l0yWcThmGpyvpa/OEgg87Qez5KB6vS6lYK8r/qeZB3a70FbH82kHlY7s4KvV2F w8Wcpj6xz41kEeLpbqO4+9k7TZBJr7VVEzOGbT7xqunWJyo1Jg5Kw8EfkD88zSSQn4o7 Eg4LzPAc+FsiyoxDno+7ezeDWns8rUuwrZPbH3L31bpvpMjfF5dogpCqjblHo9TgAA2x ranynLQvo8X8TMLi35w3DWD4odDjHjFWnCzilzPjVbrVcfEXiEI3+GG0w8zCWGIumLCy f8dPwdngzLbDeSOD996Tuz8HDuiOtVzD5+geUy6a1GZ70X/m3njFn6Lm42jZamzWxoP7 QoGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=sMnqkOMIhH/QsYn8n3PmQhFB8nSV+DDKJs7BsxontKM=; b=lGAnz1nlHJl1gmqQsM358QGHSCWrtStgKgKAuZrQNYKVlOJKROAbAcjhB8JHTAYjKF keFcm6QSXiwZEo3ChE4kUhcFMo8HwSmZrruy44eAwkjFh1Qu+dW+Vnj/RMitUTMe6wTG y6LijLzc0y5zJnoK1hiPHSHk5arZrfEzlRJkKKnpfASdnsZq4mRnirlf/PQzS6KzGKKV ASLU8zK20hjps7jmvniRM1EJx7JGPF1AvMOMMDtrrJteoommEtije0jWWmQEztXsV7Ee fdVn2daovLXF1U7qg0tSi0W7mtcMW2FOIzDisJnCf9gl/8v3NhSTXyJmBfnNUeoyS6Bj sZqA== X-Gm-Message-State: AFeK/H1/exnZrVZ8JtH3BA3kSCKBqXwlUjdoTond/8jH7cmldXYHwWNqnQVMezsaA16Piw== X-Received: by 10.84.174.197 with SMTP id r63mr16417943plb.67.1491587987143; Fri, 07 Apr 2017 10:59:47 -0700 (PDT) Received: from [192.168.20.13] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id y7sm10843711pfk.93.2017.04.07.10.59.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Apr 2017 10:59:45 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r316591 - head/sys/dev/tpm From: Ngie Cooper X-Mailer: iPhone Mail (14E277) In-Reply-To: Date: Fri, 7 Apr 2017 10:59:45 -0700 Cc: "David E. O'Brien" , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <39DE48A2-9526-497E-B178-CE78B2EF4020@gmail.com> References: <201704062221.v36MLnr7092648@repo.freebsd.org> To: Xin LI X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Apr 2017 17:59:48 -0000 > On Apr 7, 2017, at 10:17, Xin LI wrote: >=20 > No, David's change was correct. >=20 > The code context is something like: >=20 > #ifdef __FreeBSD__ > [...] > #else /* OpenBSD */ > ... > #ifdef __FreeBSD__ /* -- this portion got removed -- */ > ... > #else > ... > #endif > [...] > #endif So, in short David enabled suspend/resume support in tpm(4)... (it looks lik= e it was disabled before, just based on the variable names/calls)? Why wasn'= t that clearly stated in the commit? Thanks, -Ngie=