From owner-svn-src-all@freebsd.org Thu Jun 28 13:16:32 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E28331033AA2; Thu, 28 Jun 2018 13:16:31 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6D0807B5F7; Thu, 28 Jun 2018 13:16:31 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w5SDGQkg013220; Thu, 28 Jun 2018 06:16:26 -0700 (PDT) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w5SDGQeH013219; Thu, 28 Jun 2018 06:16:26 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201806281316.w5SDGQeH013219@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r335629 - in head: share/man/man4 sys/dev/vt/hw/vga In-Reply-To: <20180628093608.33yvnrwmmtj44get@mac.bytemobile.com> To: "Roger Pau Monn?" Date: Thu, 28 Jun 2018 06:16:26 -0700 (PDT) CC: Ian Lepore , rgrimes@freebsd.org, Alexey Dokuchaev , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jun 2018 13:16:32 -0000 > On Tue, Jun 26, 2018 at 10:18:39AM -0600, Ian Lepore wrote: > > On Tue, 2018-06-26 at 08:55 -0700, Rodney W. Grimes wrote: > > > > > > > > On Tue, Jun 26, 2018 at 05:21:27AM +0000, Alexey Dokuchaev wrote: > > > > > > > > > > On Mon, Jun 25, 2018 at 08:43:51AM -0700, Rodney W. Grimes wrote: > > > > > > > > > > > > > > > > > > > > New Revision: 335629 > > > > > > > URL: https://svnweb.freebsd.org/changeset/base/335629 > > > > > > > > > > > > > > Log: > > > > > > > ? vt: add option to ignore NO_VGA flag in ACPI > > > > > > > ?? > > > > > > > ? To workaround buggy firmware that sets this flag when > > > > > > > there's actually > > > > > > > ? a VGA present. > > > > > > > ?? > > > > > > > ? Reported and tested by: Yasuhiro KIMURA > > > > > > e.org> > > > > > > > ? Sponsored by: Citrix Systems R&D > > > > > > > ? Reviewed by: kib > > > > > > > ? Differential revision: https://reviews.freebsd.org/D > > > > > > > 16003 > > > > > > It is generally best to avoid double negatives, > > > > > > couldnt this of been better named? (hw.vga.acpi_force_vga) > > > > > Yes please; I get constantly confused when calculating negatives > > > > > and > > > > > often get them wrong. > > > > This is specifically done to workaround a firmware bug where some > > > > buggy firmwares set the NO_VGA flag in ACPI. > > > We are not conflicted about working around the buggy ACPI. > > > > > > > > > > > So the option does > > > > exactly what the name says, it ignores the NO_VGA flag in ACPI. IMO > > > > acpi_force_vga is not as descriptive as the current name. > > > Interestingly that is the text you use to describe it in the man > > > page, so it seems as if it is good for the description, but not > > > good for the name of the flag itself? > > > > > > .It Va hw.vga.acpi_ignore_no_vga > > > Set to 1 to force the usage of the VGA driver regardless of whether > > > ACPI IAPC_BOOT_ARCH signals no VGA support. > > > Can be used to workaround firmware bugs in the ACPI tables. > > > > > > This does not mention the ACPI table entry being over ridden, > > > if (flags & ACPI_FADT_NO_VGA) > > > > > > Further digging I believe you have placed this in the wrong > > > part of the hierarchy.??You put it in hw.vga, and it really > > > should be in hw.acpi. > > > Maybe hw.acpi.bootflags.ignore.no_vga. > > > > > > Are there any other bootflags we may want to ignore? > > > > > > Regards, > > > > > > There is ACPI_FADT_NO_CMOS_RTC, with an associated tunable > > hw.atrtc.enabled (default is -1), which can be: Shouldnt this really be in hw.acpi..... > > > > ? -1 - enabled unless acpi says ACPI_FADT_NO_CMOS_RTC > > ? ?0 - unconditionally disabled > > ? ?1 - unconditionally enabled > > > > The idea was that if RTC is provided by EFI runtime services, this flag > > would indicate that old-school CMOS RTC drivers should not be used. > > ?But, predictably, it turns out there are bioses that set this flag > > even when booting in legacy non-efi mode, leading to a need to ignore > > the flag and force use of the old driver. > > I could take this approach for vt and add hw.vt.enabled = { -1, 0, 1 } > if that seems better. Lets not scatter more ACPI stuff into non ACPI parts of the sysctl oid tree. If you do go this route it should really be in hw.acpi.* -- Rod Grimes rgrimes@freebsd.org