From owner-svn-src-all@freebsd.org Sun Aug 23 13:53:22 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 341809C06A2; Sun, 23 Aug 2015 13:53:22 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: from mail-wi0-x236.google.com (mail-wi0-x236.google.com [IPv6:2a00:1450:400c:c05::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BE48134D; Sun, 23 Aug 2015 13:53:21 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: by wicne3 with SMTP id ne3so50546713wic.0; Sun, 23 Aug 2015 06:53:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-type:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=KoO7HZKI6XTjq8N67UL0gJ6WHG+HdWLfQ7kweNESo6E=; b=vQ0/lUd7bPSgUWA7/H68FSuG8ul1vWzSdYvPtQerW6f31B3h4t+Xr5sO8GOo5JTJae aF3k9OmhxFlWD5wbLry3B6EdGrLgWs2GlUS8qcH3LidQtZaeP/AbX8wrz28JK/AWUpBO +ioGVApKM3EAjMuSZY45RHJ4LwZVA5a8iTWN5MaI54JiPJNn4Y1C4Kuc/vw3wM+FTiYO zR8+t9gglAbEtjK6tnGA6a1KZVRWweyz2Y6vz0Zwo3s53Qa6VVdYKuAv/EFzpHlttMjy qZkISgpCaWN03Zap+sFMS2xq97gVHqIAH+Ik6Rv+zsbTtvWn20sAZnvaxBEhFxI0uKmj D4DA== X-Received: by 10.180.105.234 with SMTP id gp10mr21145817wib.40.1440338000210; Sun, 23 Aug 2015 06:53:20 -0700 (PDT) Received: from brick.home (adik184.neoplus.adsl.tpnet.pl. [79.184.192.184]) by smtp.gmail.com with ESMTPSA id y15sm11734448wib.7.2015.08.23.06.53.18 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 23 Aug 2015 06:53:18 -0700 (PDT) Sender: =?UTF-8?Q?Edward_Tomasz_Napiera=C5=82a?= Date: Sun, 23 Aug 2015 15:31:48 +0200 From: Edward Tomasz Napierala To: Dmitry Sivachenko Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r286329 - in head/etc: defaults rc.d Message-ID: <20150823133148.GB9866@brick.home> Mail-Followup-To: Dmitry Sivachenko , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201508051738.t75Hc2MP038354@repo.freebsd.org> <92FC24C2-8B61-4B02-87E0-D4C6D4DA8ECF@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <92FC24C2-8B61-4B02-87E0-D4C6D4DA8ECF@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Aug 2015 13:53:22 -0000 On 0806T1152, Dmitry Sivachenko wrote: > > > On 5 авг. 2015 г., at 20:38, Edward Tomasz Napierala wrote: > > > > Author: trasz > > Date: Wed Aug 5 17:38:02 2015 > > New Revision: 286329 > > URL: https://svnweb.freebsd.org/changeset/base/286329 > > > > Log: > > Make rctl_enable rc variable actually work. To avoid breaking existing > > setups that worked before, flip the default to "YES". Most people don't > > have /etc/rctl.conf, so they won't be affected in any way. > > > > MFC after: 1 month > > Sponsored by: The FreeBSD Foundation > > > > Modified: > > head/etc/defaults/rc.conf > > head/etc/rc.d/rctl > > > > Modified: head/etc/defaults/rc.conf > > ============================================================================== > > --- head/etc/defaults/rc.conf Wed Aug 5 17:21:42 2015 (r286328) > > +++ head/etc/defaults/rc.conf Wed Aug 5 17:38:02 2015 (r286329) > > @@ -664,7 +664,7 @@ opensm_enable="NO" # Opensm(8) for infin > > casperd_enable="YES" # casperd(8) daemon > > > > # rctl(8) requires kernel options RACCT and RCTL > > -rctl_enable="NO" # Load rctl(8) rules on boot > > +rctl_enable="YES" # Load rctl(8) rules on boot > > > Sad to see that rarely used feature has default as "YES". Requiring users to enable it in rc.conf would break existing setups, but it's also that it doesn't make much sense, IMHO. The etc/rc.d/rctl script was modeled after etc/rc.d/sysctl, and sysctl doesn't have the enable knob either. > PS: Please adjust rc.conf(5) accordingly, it assumes the default is NO. Done.