Date: Thu, 16 Sep 2004 04:02:23 -0000 From: Andrew Thompson <andy@fud.org.nz> To: pf4freebsd@freelists.org Subject: [pf4freebsd] Re: pfflowd port Message-ID: <20040225040421.GA16996@kate.fud.org.nz> In-Reply-To: <20040224023435.GB4129@kt-is.co.kr> References: <20040224001503.GA99464@kate.fud.org.nz> <200402240135.55752.max@love2party.net> <20040224012947.GA99698@kate.fud.org.nz> <20040224023435.GB4129@kt-is.co.kr>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Feb 24, 2004 at 11:34:35AM +0900, Pyun YongHyeon wrote: > On Tue, Feb 24, 2004 at 02:29:47PM +1300, Andrew Thompson wrote: > > > On Tuesday 24 February 2004 01:15, Andrew Thompson wrote: > > > > Hi all, > > > > > > > > I have created a port for pfflowd and thought i'd get feedback b= efore > > > > submitting a PR. > > > > > > > > It can be found @ > > > > > > > > http://www.fud.org.nz/pfflowd-port.tar.gz > > >=20 > >=20 > > It generated a gcc warning, as addr->sin_port is a uint16_t which ca= nt > > be negative or >65536. -Werror made this fatal. > >=20 > How about this? >=20 > parse_hostport(const char *s, struct sockaddr_in *addr) > { [snip] Thanks Max and Pyun for your feedback. I have rolled another attempt, and i'll send a PR if its ok. http://www.fud.org.nz/pfflowd-port.tar.gz The only thing I was unsure about was to use ${CP} or ${CAT} to copy the pidfile.* into the working dir. Andy
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040225040421.GA16996>