From owner-svn-src-head@FreeBSD.ORG Sun Jul 28 12:45:12 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 425AE309; Sun, 28 Jul 2013 12:45:12 +0000 (UTC) (envelope-from tijl@coosemans.org) Received: from mailrelay001.isp.belgacom.be (mailrelay001.isp.belgacom.be [195.238.6.51]) by mx1.freebsd.org (Postfix) with ESMTP id 550A42BA2; Sun, 28 Jul 2013 12:45:10 +0000 (UTC) X-Belgacom-Dynamic: yes X-Cloudmark-SP-Filtered: true X-Cloudmark-SP-Result: v=1.1 cv=TVAeEZsMflEN/Gl6LVQhGIMIvPmivZZxTpw3qWPxQr8= c=1 sm=2 a=xnulW3ATU38A:10 a=ZxPGInapWdQA:10 a=YqRfAJJkAAAA:8 a=uZvujYp8AAAA:8 a=yV6n4f_wk2LWa0TmYloA:9 a=CjuIK1q_8ugA:10 a=PvG2Zffer3IA:10 a=UIDpq6-GphUA:10 a=7mm7v_gwTSDN0Q6uc88A:9 a=0CaTwavtbm8A:10 a=_G8qimlXLBUA:10 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AmwGAJgR9VFR8YfH/2dsb2JhbABbgwY1viKBFxd0giQBAQVWIxALDgoJJQ8qHgYTiBQIt1CNLoJPB4QFA5ASh0yBKoh4hyuDFjo Received: from 199.135-241-81.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([81.241.135.199]) by relay.skynet.be with ESMTP; 28 Jul 2013 14:45:03 +0200 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.14.7/8.14.7) with ESMTP id r6SCj2Zb002051; Sun, 28 Jul 2013 14:45:02 +0200 (CEST) (envelope-from tijl@coosemans.org) Date: Sun, 28 Jul 2013 14:44:56 +0200 From: Tijl Coosemans To: David Chisnall Subject: Re: svn commit: r253563 - head/contrib/libstdc++/include/c_std Message-ID: <20130728144456.486359e0@kalimero.tijl.coosemans.org> In-Reply-To: References: <201307231023.r6NANhGf065713@svn.freebsd.org> <20130725201948.2f5ae808@kalimero.tijl.coosemans.org> <7D9DA326-0F32-44D2-92F9-EED0751F9AE0@FreeBSD.org> <20130726122654.19448832@kalimero.tijl.coosemans.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA256; boundary="Sig_/sMaHl=NSlGb1CPzpvCdD.I_"; protocol="application/pgp-signature" Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Jul 2013 12:45:12 -0000 --Sig_/sMaHl=NSlGb1CPzpvCdD.I_ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Fri, 26 Jul 2013 11:51:43 +0100 David Chisnall wrote: > On 26 Jul 2013, at 11:26, Tijl Coosemans wrote: >> On Fri, 26 Jul 2013 10:43:07 +0100 David Chisnall wrote: >>> On 25 Jul 2013, at 19:19, Tijl Coosemans wrote: >>>> This also >>>> broke compilation of C code with -D_XOPEN_SOURCE=3D500. >>>=20 >>> Do you have a test case for this? >>=20 >> % cc -c test.c -D_XOPEN_SOURCE=3D500 -Wall -std=3Dgnu89 >> test.c:5:10: warning: implicit declaration of function 'isnan' >> [-Wimplicit-function-declaration] >> return( isnan( d )); >> ^ >> 1 warning generated. >>=20 >> The isnan function is part of SUSv2: >> http://pubs.opengroup.org/onlinepubs/7990989775/xsh/isnan.html >>=20 >> _XOPEN_SOURCE is handled in sys/cdefs.h. It sets the following macros: >> #define __XSI_VISIBLE 500 >> #define __POSIX_VISIBLE 199506 >> #define __ISO_C_VISIBLE 1990 >=20 > So, isnan and isinf should be visible in functions when in > __ISO_C_VISIBLE < 1999 and __XSI_VISIBLE < 600, and __XSI_VISIBLE >=3D 5= 00? Is it possible to put them back where they were but behind #if __cplusplus < 201103L ? That would be the least disruptive. --Sig_/sMaHl=NSlGb1CPzpvCdD.I_ Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (FreeBSD) iF4EAREIAAYFAlH1Ek0ACgkQfoCS2CCgtivDJAD+LWmjpWTZoY5liBpgRUgMUKvr +xAsX9JTmw84SCxrDrMA/1nnfUvMqaSZjldlr7RHNPYxnAY/pvAbvc9Pf5SB3P8a =99UG -----END PGP SIGNATURE----- --Sig_/sMaHl=NSlGb1CPzpvCdD.I_--