Date: Fri, 20 May 2011 19:19:02 +0200 (CEST) From: Christoph Moench-Tegeder <cmt@burggraben.net> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/157217: [PATCH] unbreak graphics/graphviz on -RELEASE (missing log2()) Message-ID: <20110520171902.A1787AC840@elch.exwg.net> Resent-Message-ID: <201105201740.p4KHeBTN081028@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 157217 >Category: ports >Synopsis: [PATCH] unbreak graphics/graphviz on -RELEASE (missing log2()) >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Fri May 20 17:40:11 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Christoph Moench-Tegeder >Release: FreeBSD 8.2-RELEASE-p1 amd64 >Organization: >Environment: System: FreeBSD elch.exwg.net 8.2-RELEASE-p1 FreeBSD 8.2-RELEASE-p1 #7: Thu Apr 21 15:56:09 CEST 2011 cmt@elch.exwg.net:/usr/obj/usr/src/sys/CMT amd64 graphics/graphviz 2.28.0 >Description: The build of graphics/graphviz on -RELEASE fails because log2() is not defined on those versions. The same problem (log2f() in that case) happened with graphics/gegl some time ago (see ports/155183). >How-To-Repeat: try to build graphviz on 8.2-RELEASE >Fix: I blatantly copied the version check from graphics/gegl/files/patch-tools_exp_combine.cpp diff -Nru graphics/graphviz.orig/files/patch-lib-ortho-trapezoid.c graphics/graphviz/files/patch-lib-ortho-trapezoid.c --- graphics/graphviz.orig/files/patch-lib-ortho-trapezoid.c 1970-01-01 01:00:00.000000000 +0100 +++ graphics/graphviz/files/patch-lib-ortho-trapezoid.c 2011-05-20 18:59:05.000000000 +0200 @@ -0,0 +1,14 @@ +--- lib/ortho/trapezoid.c.orig 2011-05-20 18:55:22.000000000 +0200 ++++ lib/ortho/trapezoid.c 2011-05-20 18:57:31.000000000 +0200 +@@ -30,6 +30,11 @@ + #define log2(x) (log(x)/log(2)) + #endif + ++#include <sys/param.h> ++#if __FreeBSD_version <= 704100 || (__FreeBSD_version >= 800000 && __FreeBSD_version < 802502) || (__FreeBSD_version >= 900000 && __FreeBSD_version < 900027) ++#define log2(x) (log(x)/log(2)) ++#endif ++ + /* Node types */ + + #define T_X 1 >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110520171902.A1787AC840>