From owner-dev-commits-src-all@freebsd.org Thu Apr 29 15:19:03 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4608662DAEF; Thu, 29 Apr 2021 15:19:03 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FWK0R1Z8fz4nM1; Thu, 29 Apr 2021 15:19:03 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.codepro.be", Issuer "R3" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id 0C45EAF16; Thu, 29 Apr 2021 15:19:03 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id 0679B15E37; Thu, 29 Apr 2021 17:19:00 +0200 (CEST) From: "Kristof Provost" To: "Shawn Webb" Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: e86bddea9fe6 - main - pf: Split pf_rule into kernel and user space versions Date: Thu, 29 Apr 2021 17:18:59 +0200 X-Mailer: MailMate (1.13.2r5673) Message-ID: <3FE30BC8-EA8D-40E9-9D51-2906A6561B50@FreeBSD.org> In-Reply-To: <20210429151414.iao5i7hjmmztfos6@mutt-hbsd> References: <202101052237.105MbsJW081542@gitrepo.freebsd.org> <20210429151414.iao5i7hjmmztfos6@mutt-hbsd> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Apr 2021 15:19:03 -0000 On 29 Apr 2021, at 17:14, Shawn Webb wrote: > On Tue, Jan 05, 2021 at 10:37:54PM +0000, Kristof Provost wrote: >> The branch main has been updated by kp: >> >> URL: = >> https://cgit.FreeBSD.org/src/commit/?id=3De86bddea9fe62d5093a1942cf219= 50b3c5ca62e5 >> >> commit e86bddea9fe62d5093a1942cf21950b3c5ca62e5 >> Author: Kristof Provost >> AuthorDate: 2020-12-05 13:32:54 +0000 >> Commit: Kristof Provost >> CommitDate: 2021-01-05 22:35:36 +0000 >> >> pf: Split pf_rule into kernel and user space versions >> >> No functional change intended. >> >> MFC after: 2 weeks >> Sponsored by: Orange Business Services >> Differential Revision: https://reviews.freebsd.org/D27758 > > Key Kristof, > > This commit breaks the security/expiretable port. Specifically, the > guarding of the pf_state struct, which expiretable uses directly. > Yeah, it=E2=80=99s come up before: = https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253547 Tl;dr: The expiretable port used a struct it should not have been using. = That part of the code never[*] worked, but it=E2=80=99s not actually used= = anyway. Renato has a patch to fix the port by simply deleting the = offending code. Best regards, Kristof [*] Not in recent memory anyway. At least since 2012. That=E2=80=99s when= the = pf code was moved around in the tree and I=E2=80=99ve not dug further to = see = when this started to be wrong.