From owner-svn-src-head@FreeBSD.ORG  Sat Nov 10 22:29:03 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 1CE753E4;
 Sat, 10 Nov 2012 22:29:03 +0000 (UTC) (envelope-from bright@mu.org)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
 by mx1.freebsd.org (Postfix) with ESMTP id D706B8FC12;
 Sat, 10 Nov 2012 22:29:01 +0000 (UTC)
Received: from Alfreds-MacBook-Pro-5.local
 (c-67-180-208-218.hsd1.ca.comcast.net [67.180.208.218])
 by elvis.mu.org (Postfix) with ESMTPSA id 923DD1A3C49;
 Sat, 10 Nov 2012 14:29:01 -0800 (PST)
Message-ID: <509ED52C.3030308@mu.org>
Date: Sat, 10 Nov 2012 14:29:00 -0800
From: Alfred Perlstein <bright@mu.org>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7;
 rv:16.0) Gecko/20121026 Thunderbird/16.0.2
MIME-Version: 1.0
To: Ian Lepore <freebsd@damnhippie.dyndns.org>
Subject: Re: svn commit: r242847 - in head/sys: i386/include kern
References: <201211100208.qAA28e0v004842@svn.freebsd.org>
 <CAF6rxg=HPmQS1T-LFsZ=DuKEqH30iJFpkz+JGhLr4OBL8nohjg@mail.gmail.com>
 <509DC25E.5030306@mu.org> <509E3162.5020702@FreeBSD.org>
 <509E7E7C.9000104@mu.org>
 <CAF6rxgmV8dx-gsQceQKuMQEsJ+GkExcKYxEvQ3kY+5_nSjvA3w@mail.gmail.com>
 <509E830D.5080006@mu.org> <1352568275.17290.85.camel@revolution.hippie.lan>
In-Reply-To: <1352568275.17290.85.camel@revolution.hippie.lan>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 Alfred Perlstein <alfred@freebsd.org>, Eitan Adler <eadler@freebsd.org>,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 10 Nov 2012 22:29:03 -0000

On 11/10/12 9:24 AM, Ian Lepore wrote:
> On Sat, 2012-11-10 at 08:38 -0800, Alfred Perlstein wrote:
>> On 11/10/12 8:25 AM, Eitan Adler wrote:
>>> On 10 November 2012 11:19, Alfred Perlstein <bright@mu.org> wrote:
>>>> Please consult the svn log for this file, it's relatively clear
>> just in the
>>>> commit logs/comments.  Grep for 384/512 and look around.
>>> Can this reasoning be added as a comment? I did grep for 384 in the
>> log, but
>>> a) I didn't find the answer
>>> b) one shouldn't have to.
>>>
>>>
>> It probably could be added, but then a bunch of other people would
>> complain about the comment being too wordy or "not in English".
> The fact that such a thing could happen explains much about the current
> state of the code.  An outsider could easily come to the conclusion that
> the FreeBSD motto is something along the lines of "It should be as hard
> to read as it was to write."
>
> -- Ian
>
>
Ian,

I am very much in favor of commenting code.  In fact I would like to 
have more "story like" comments
that explain things in the code.

Unfortunately, EVERY TIME I DO THIS I get a bikeshed on it and it soaks 
up a whole day if not more.

FreeBSD community needs to rally behind people, not block them for 
making changes like these.

Why do you think no one had the balls to touch maxusers in the first place?
... If you guessed "not worth the bikeshed" you'd be right.

-Alfred