From owner-svn-src-all@freebsd.org Sun Dec 6 17:03:35 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7796B4A2D0C for ; Sun, 6 Dec 2020 17:03:35 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Cpt7W2qsqz4XkN for ; Sun, 6 Dec 2020 17:03:35 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wm1-f54.google.com with SMTP id x22so9486615wmc.5 for ; Sun, 06 Dec 2020 09:03:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=G3bSvctU8Erd2N8kOBTy3z9A1tXG1SqQrMa8B27FJTI=; b=OrYpc5E96S8XyJENSsupj0IkWbSDY1Q+fCdo8YvkmltgL/YmLeULBVx9a4boj/Z7/7 BACtXB5ApT2kkTRoB+gTiFNOSsQ4FlasuoJperNUTnmKi9pM7aFQo8uQTGStzztLvMDu 95/ZnQWRGz71JuBd1+gbQeI+u7i2o5VTM8eWNqB5eWkrY8S8S1Z5MwcK7iVl3RE4eqe/ g03zC3/c6vDkOHnY8g/WQ5BtznoXfjNifxAyVLQkTu15KcaUMsSCQ2YQLDnqT8J1RpGX 4wk9TPqxIKAb9M2T8FZwM59d15J+70ciJl5LLL5HK7+o+RYFAgnlYzaHGb5pRO3Colxv d18Q== X-Gm-Message-State: AOAM533FJXdxIPNfnXIpzTJTLkqe6BrqRsT+lchXmK2yuhRI62PrSQ0/ 6/eyeJAUPeixsgfRRKlh5NFa/g== X-Google-Smtp-Source: ABdhPJwvWs00S7z0RJVEYOV0Oe1vuRHNRmS4us44Pjq40FqGsrRKjCUAu02NmGwsapKA5UGEOsmHNA== X-Received: by 2002:a05:600c:2042:: with SMTP id p2mr14735572wmg.152.1607274213552; Sun, 06 Dec 2020 09:03:33 -0800 (PST) Received: from [192.168.149.251] (trinity-students-nat.trin.cam.ac.uk. [131.111.193.104]) by smtp.gmail.com with ESMTPSA id n17sm2517104wmc.33.2020.12.06.09.03.32 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 06 Dec 2020 09:03:32 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Subject: Re: svn commit: r368375 - head/sys/kern From: Jessica Clarke In-Reply-To: <202012060459.0B64xO7Z064250@repo.freebsd.org> Date: Sun, 6 Dec 2020 17:03:31 +0000 Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: 7bit Message-Id: References: <202012060459.0B64xO7Z064250@repo.freebsd.org> To: Mateusz Guzik X-Mailer: Apple Mail (2.3608.120.23.2.4) X-Rspamd-Queue-Id: 4Cpt7W2qsqz4XkN X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Dec 2020 17:03:35 -0000 Hi Mateusz, This looks like a behavioural change to me. Was that intended and a bug fix (in which case, it should have been documented in the commit message) or not? See below for the exact change. On 6 Dec 2020, at 04:59, Mateusz Guzik wrote: > +static int > +namei_getpath(struct nameidata *ndp) > +{ > + struct componentname *cnp; > + int error; > + > + cnp = &ndp->ni_cnd; > + > + /* > + * Get a buffer for the name to be translated, and copy the > + * name into the buffer. > + */ > + cnp->cn_pnbuf = uma_zalloc(namei_zone, M_WAITOK); > + if (ndp->ni_segflg == UIO_SYSSPACE) { > + error = copystr(ndp->ni_dirp, cnp->cn_pnbuf, MAXPATHLEN, > + &ndp->ni_pathlen); > + } else { > + error = copyinstr(ndp->ni_dirp, cnp->cn_pnbuf, MAXPATHLEN, > + &ndp->ni_pathlen); > + } > + > + if (__predict_false(error != 0)) { > + return (error); This does not call namei_cleanup_cnp. > @@ -531,31 +568,11 @@ namei(struct nameidata *ndp) > ndp->ni_lcf = 0; > ndp->ni_vp = NULL; > > - /* > - * Get a buffer for the name to be translated, and copy the > - * name into the buffer. > - */ > - cnp->cn_pnbuf = uma_zalloc(namei_zone, M_WAITOK); > - if (ndp->ni_segflg == UIO_SYSSPACE) > - error = copystr(ndp->ni_dirp, cnp->cn_pnbuf, MAXPATHLEN, > - &ndp->ni_pathlen); > - else > - error = copyinstr(ndp->ni_dirp, cnp->cn_pnbuf, MAXPATHLEN, > - &ndp->ni_pathlen); > - > + error = namei_getpath(ndp); > if (__predict_false(error != 0)) { > - namei_cleanup_cnp(cnp); But it used to be called in that case here. > return (error); > } Jess