From nobody Fri Oct 17 16:43:20 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cp9cq27WFz6CKRK for ; Fri, 17 Oct 2025 16:43:39 +0000 (UTC) (envelope-from rlibby@gmail.com) Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cp9cq0fm6z3K0R for ; Fri, 17 Oct 2025 16:43:39 +0000 (UTC) (envelope-from rlibby@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-781421f5be6so28813527b3.0 for ; Fri, 17 Oct 2025 09:43:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760719413; x=1761324213; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tai5WQpbGipZh4x2Qbd6VlKIvDXep+nILMDRnzE0HZk=; b=t3BnJvZaDhg9llZJI9pAxqAJO5IJaLcIUpV5XAQmnZvHdJt/60mgg+O7j90EWqFVMI ORP9sMjv6ylU7YwLTvp92smWYJTdoO5Y9LyKP2YZ3tZSGCxJ0pqeEItc4uu1qDEON6zb FgL7gDxqx0Mz8uWhSen7OfZv9788lu5zZjqwNllvxBXORg8qMMl6VgrPDnzYdzlxZC3J 6Vp8lzVHE+s2314JwxPX662hprji2FqUPWI1f5Tw0hsH/oroT9LT32HVAaV+IoRN/ltR 7Lyh93JW61vpR+nZ8WcjmauPKGDkLm1ZzIH84Rn754K/2fuXO2qxopOFaGbDkAblt9rR ElwA== X-Forwarded-Encrypted: i=1; AJvYcCWeQnvq3t4vHH03kkwKcEXDcwj3WR8ZBnLpFypFLyagiZkZ9uX77jXxmGhxhbmYN0ckzVQfeXoQDQ87EKbEI8ZMFbkJnw==@freebsd.org X-Gm-Message-State: AOJu0YyLMHSnIuNw9jZ/sFXy7Wm66yIUMxapKaETG62veDE6Dcgdx8nW vmiCBHAJpN10x956gEpXRnIUx9FTUceRnxFUwN0vg8jB5mrn6cJqsjVrbvKf7feUkts= X-Gm-Gg: ASbGncsElWT/u5TWDS9J64v0Hz8r7HWe7NR11C4YkU3NIUn3sUSMPBxMluY4LuObaBQ VIJDCnHFahA/ns/FbLeAr2KB4mbmpjh+PqfxppLMtNhBr5QcvbqNbiFICygssAI7zSLUNFaEB91 0pqyGVU26+HD+N+uy5xc1zR1FT01M6s0iqZEVy5iyI0x2oyBmh5dch1I0FnUicXLViETM2fnLqm fVp2Z/+lMa4xV7+vc9wlUlM6ef3xfZj7sEuyMfYZ+Pq2YgJhs4bFu6N5RTLFPUGhFcUqIS01WM5 tIIIgdSEd+80tb8FyF1CfEkQgnCRxNpcFpL1eTyzx7hHHKHkfZ5YvQPf5ONNsR/vqJpqexwd1WQ BCsFtCLW+yq5hH4b4GxNPFoQM70r1u9hkX9zg1ERmz0OrZaqAT91/eZmKhO2cna+sliGk6uqIFu i5Rk00MRb989OGHvKwiyQNvmEG5Brm5WU0xTR2Pwo= X-Google-Smtp-Source: AGHT+IFk4Dhh5QxsczezEvn4/Myszzbu9gZjwg3PQ3iYkhbw3q2/mwH8w5YS6rZ4NWawKQmC8yLKCg== X-Received: by 2002:a05:690c:338a:b0:739:7377:fda6 with SMTP id 00721157ae682-7836d2d6462mr41489127b3.42.1760719412907; Fri, 17 Oct 2025 09:43:32 -0700 (PDT) Received: from mail-yw1-f176.google.com (mail-yw1-f176.google.com. [209.85.128.176]) by smtp.gmail.com with ESMTPSA id 00721157ae682-784672a3e16sm111607b3.11.2025.10.17.09.43.32 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Oct 2025 09:43:32 -0700 (PDT) Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-781421f5be6so28813297b3.0 for ; Fri, 17 Oct 2025 09:43:32 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUDTm4EGwDKLXy/QOvqDQAVK3KhHe8Zwc2eYrzq3LswA2g8vs5RznmxzmK3fApfmtc0159y2/+6sobTyjZQwe2iRtKyqA==@freebsd.org X-Received: by 2002:a05:690e:11c4:b0:63e:1ca0:be73 with SMTP id 956f58d0204a3-63e1ca0c207mr2164662d50.37.1760719411795; Fri, 17 Oct 2025 09:43:31 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <202510162205.59GM5ZvD042942@gitrepo.freebsd.org> In-Reply-To: From: Ryan Libby Date: Fri, 17 Oct 2025 09:43:20 -0700 X-Gmail-Original-Message-ID: X-Gm-Features: AS18NWDOI7vD-owN-IYKQevM9EL5lc7dOzZKONklI3QsgrIGz-UqVcxkcEHY8gI Message-ID: Subject: Re: git: 0050289464fa - main - style(9): white space after ; and around binary operators To: Mark Johnston Cc: Rick Macklem , "David E. O'Brien" , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_RCPT(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4cp9cq0fm6z3K0R On Thu, Oct 16, 2025 at 4:58=E2=80=AFPM Mark Johnston w= rote: > > On Thu, Oct 16, 2025 at 04:21:45PM -0700, Rick Macklem wrote: > > Please be aware of the following snippets from "man 9 style": > > > > In general code can be considered "new code" when it makes up about 50% > > or more of the file(s) involved. This is enough to break precedents in > > the existing code and use the current style guidelines. > > > > Stylistic changes (including whitespace changes) are hard on the source > > repository and are to be avoided without good reason. > > +1 > > This kind of change accomplishes nothing except to be a source of merge > conflicts for others to deal with. > Not to pile on, but I would also suggest to avoid touching unrelated code in a single commit if not necessary. It helps avoid entanglement in backports. > > rick > > > > On Thu, Oct 16, 2025 at 3:05=E2=80=AFPM David E. O'Brien wrote: > > > > > > CAUTION: This email originated from outside of the University of Guel= ph. Do not click links or open attachments unless you recognize the sender = and know the content is safe. If in doubt, forward suspicious emails to ITh= elp@uoguelph.ca. > > > > > > The branch main has been updated by obrien: > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D0050289464fa56ec79e060= b8d8378b9ff7145a0e > > > > > > commit 0050289464fa56ec79e060b8d8378b9ff7145a0e > > > Author: David E. O'Brien > > > AuthorDate: 2025-10-15 05:22:00 +0000 > > > Commit: David E. O'Brien > > > CommitDate: 2025-10-16 22:02:50 +0000 > > > > > > style(9): white space after ; and around binary operators > > > > > > in for() loops. Also, use 'while', where only the > > > conditional test of 'for' was used. > > > > > > Reviewed by: sjg