From owner-svn-src-all@FreeBSD.ORG Thu Jan 29 20:34:28 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 33F3D1065679; Thu, 29 Jan 2009 20:34:28 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.terabit.net.ua (mail.terabit.net.ua [195.137.202.147]) by mx1.freebsd.org (Postfix) with ESMTP id C3EC28FC24; Thu, 29 Jan 2009 20:34:27 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from skuns.zoral.com.ua ([91.193.166.194] helo=mail.zoral.com.ua) by mail.terabit.net.ua with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63 (FreeBSD)) (envelope-from ) id 1LSdaj-00026E-MW; Thu, 29 Jan 2009 22:34:25 +0200 Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id n0TKYMwJ038787 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 29 Jan 2009 22:34:22 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3) with ESMTP id n0TKYMGe072894; Thu, 29 Jan 2009 22:34:22 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3/Submit) id n0TKYMeA072810; Thu, 29 Jan 2009 22:34:22 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 29 Jan 2009 22:34:22 +0200 From: Kostik Belousov To: John Baldwin Message-ID: <20090129203422.GA1906@deviant.kiev.zoral.com.ua> References: <200901291647.n0TGlFHZ058776@svn.freebsd.org> <200901291209.14313.jhb@freebsd.org> <20090129181523.GA2471@deviant.kiev.zoral.com.ua> <200901291343.55485.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="82I3+IH0IqGh5yIs" Content-Disposition: inline In-Reply-To: <200901291343.55485.jhb@freebsd.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua X-Virus-Scanned: mail.terabit.net.ua 1LSdaj-00026E-MW 06130a34160acc485ef460ae9c893c48 X-Terabit: YES Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Edward Tomasz Napierala Subject: Re: svn commit: r187894 - head/sys/ufs/ffs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jan 2009 20:34:28 -0000 --82I3+IH0IqGh5yIs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 29, 2009 at 01:43:54PM -0500, John Baldwin wrote: > On Thursday 29 January 2009 1:15:23 pm Kostik Belousov wrote: > > On Thu, Jan 29, 2009 at 12:09:13PM -0500, John Baldwin wrote: > > > On Thursday 29 January 2009 11:47:15 am Edward Tomasz Napierala wrote: > > > > Author: trasz > > > > Date: Thu Jan 29 16:47:15 2009 > > > > New Revision: 187894 > > > > URL: http://svn.freebsd.org/changeset/base/187894 > > > >=20 > > > > Log: > > > > Make sure the cdev doesn't go away while the filesystem is still= =20 > mounted. > > > > Otherwise dev2udev() could return garbage. > > > > =20 > > > > Reviewed by: kib > > > > Approved by: rwatson (mentor) > > > > Sponsored by: FreeBSD Foundation > > >=20 > > > Is this applicable to all filesystems? I'm curious why the VREF() on= the=20 > > > vnode associated with the cdev entry (um_devvp) is not sufficient to= =20 > prevent=20 > > > this? I would have thought that the vnode would have held a referenc= e on=20 > the=20 > > > cdev. > >=20 > > The point of this commit is that devvp vnode may be reclaimed. >=20 > So do all filesystems need this change then? I briefly looked over cd9660. It caches the cdev in the im_dev member of its mount structure, that is consequently used as an argument to dev2udev() in cd9660_getattr(). I think that typical answer to your question is "yes". --82I3+IH0IqGh5yIs Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkmCEswACgkQC3+MBN1Mb4jHbACfWS/CFL1Rz/J4Jz8L6vHmVYy+ QlcAoMN5Dq5qy/pxXxzlBLwhLXRSw0rL =1MuM -----END PGP SIGNATURE----- --82I3+IH0IqGh5yIs--