From owner-cvs-src@FreeBSD.ORG  Tue Feb  3 21:46:06 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id DDAA016A4CE; Tue,  3 Feb 2004 21:46:06 -0800 (PST)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 146CA43D1F; Tue,  3 Feb 2004 21:46:06 -0800 (PST)
	(envelope-from rwatson@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.10/8.12.10) with ESMTP id i145k50B024312;
	Tue, 3 Feb 2004 21:46:05 -0800 (PST)
	(envelope-from rwatson@repoman.freebsd.org)
Received: (from rwatson@localhost)
	by repoman.freebsd.org (8.12.10/8.12.10/Submit) id i145k5Rr024311;
	Tue, 3 Feb 2004 21:46:05 -0800 (PST)
	(envelope-from rwatson)
Message-Id: <200402040546.i145k5Rr024311@repoman.freebsd.org>
From: Robert Watson <rwatson@FreeBSD.org>
Date: Tue, 3 Feb 2004 21:46:05 -0800 (PST)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org,
	cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Subject: cvs commit: src/sys/kern tty.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Feb 2004 05:46:07 -0000

rwatson     2004/02/03 21:46:05 PST

  FreeBSD src repository

  Modified files:
    sys/kern             tty.c 
  Log:
  A variety of further cleanups to ttyinfo():
  
  - Rename temporary variable names ("tmp", "tmp2") to more informative
    names ("load", "pctcpu", "rss", ...)
  
  - Unclutter indentation and return paths: rather than lots of nested
    ifs, simply return earlier if it's not going to work out.  Simplify
    general structure and avoid "deep" code.
  
  - Comment on the thread/process selection and locking.
  
  - Correct handling of "running"/"runnable" states, avoid "unknown"
    that people were seeing for running processes.  This was due to
    a misunderstanding of the more complex state machine / inhibitors
    behavior of KSE.
  
  - Do perform ttyinfo() printing on KSE (P_SA) processes, it seems
    generally to work.
  
  While I initially attempted to formulate this as two commits (one
  layout, the other content), I concluded that the layout changes were
  really structural changes.
  
  Many elements submitted by:  bde
  
  Revision  Changes    Path
  1.207     +85 -78    src/sys/kern/tty.c