From owner-cvs-all@FreeBSD.ORG  Wed Oct 31 23:03:01 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A54DD16A418;
	Wed, 31 Oct 2007 23:03:01 +0000 (UTC)
	(envelope-from ache@nagual.pp.ru)
Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69])
	by mx1.freebsd.org (Postfix) with ESMTP id 1AD3613C4A7;
	Wed, 31 Oct 2007 23:03:00 +0000 (UTC)
	(envelope-from ache@nagual.pp.ru)
Received: from nagual.pp.ru (ache@localhost [127.0.0.1])
	by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l9VMx843091446;
	Thu, 1 Nov 2007 01:59:08 +0300 (MSK)
	(envelope-from ache@nagual.pp.ru)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nagual.pp.ru;
	s=default; t=1193871548; bh=v0YuqWLNaE1EoEjz0FHn9GzRjmYVYP4JMBRrKuw
	qveM=; l=715; h=Date:From:To:Subject:Message-ID:Mail-Followup-To:
	References:MIME-Version:Content-Type:Content-Disposition:
	Content-Transfer-Encoding:In-Reply-To:User-Agent; b=DOVsNOUa9t0nXN
	ZO++NQxobbvpOY9TOfnB/xfvo4PncBCf1oPt6iw6q+J+DqxPHhweRKyecEN7l28NzSJ
	cpWvVzidmtoMI6SQGyaG1nUHzMHBEI4KvBYYz3F+l0/0POfGj7ebsONLyJwiITsQeCH
	+5wH32LqHkj1dUI7Ehd79yQ=
Received: (from ache@localhost)
	by nagual.pp.ru (8.14.1/8.14.1/Submit) id l9VMx8wP091445;
	Thu, 1 Nov 2007 01:59:08 +0300 (MSK) (envelope-from ache)
Date: Thu, 1 Nov 2007 01:59:08 +0300
From: Andrey Chernov <ache@nagual.pp.ru>
To: Juli Mallett <juli@clockworksquid.com>,
	Alexey Dokuchaev <danfe@FreeBSD.ORG>, src-committers@FreeBSD.ORG,
	cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Message-ID: <20071031225908.GA91412@nagual.pp.ru>
Mail-Followup-To: Andrey Chernov <ache@nagual.pp.ru>,
	Juli Mallett <juli@clockworksquid.com>,
	Alexey Dokuchaev <danfe@FreeBSD.ORG>, src-committers@FreeBSD.ORG,
	cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG
References: <200710272232.l9RMWSbK072082@repoman.freebsd.org>
	<20071030200331.GA29309@toxic.magnesium.net>
	<20071031215526.GC89932@nagual.pp.ru>
	<20071031223349.GA552@FreeBSD.org>
	<20071031223727.GB90994@nagual.pp.ru>
	<20071031224313.GA18285@toxic.magnesium.net>
	<20071031224818.GA91246@nagual.pp.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20071031224818.GA91246@nagual.pp.ru>
User-Agent: Mutt/1.5.16 (2007-06-09)
Cc: 
Subject: Re: cvs commit: src/include _ctype.h
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 31 Oct 2007 23:03:01 -0000

On Thu, Nov 01, 2007 at 01:48:19AM +0300, Andrey Chernov wrote:
> > > 2. It also breaks common style ctype using for is{w}ascii(). If rever=
t=20
> > > this, is{w}ascii() should be rewritted too.
> >=20
> > That seems reasonable.
>=20
> Well, I don't want to fight here. If there general consensus that we=20
> should prefer human-readable code for __isctype(), isascii() and=20
> iswascii() in trade for some edge cases, let it be so.

=46rom second thoght, is{w}ascii() are macros and rewritting them cause=20
things like (arg++) be evaluated twice, so it is better to not touch it.=20
So I don't see the point why __isctype() so special to not looks like=20
isascii()

--=20
http://ache.pp.ru/