From owner-svn-src-all@freebsd.org Thu Nov 16 00:05:33 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1D942DEF4E4; Thu, 16 Nov 2017 00:05:33 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-it0-x233.google.com (mail-it0-x233.google.com [IPv6:2607:f8b0:4001:c0b::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E327863BEC; Thu, 16 Nov 2017 00:05:32 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-it0-x233.google.com with SMTP id n134so3882983itg.3; Wed, 15 Nov 2017 16:05:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=9FsdC53cWwFdjmccAWSaLCmYwhQ7YaNUY5RuBbcKHVA=; b=Wu0gUI8I+bjtO0nQKztvu4QMl8NHXBn5jaXAyMMcCXWbLhrHtDb4zDd2A4SmKkG6Ae CygXNhw4zi/tNp4D0irESWdwixwYmo7KleafdEhJP1b0BG9jKBpHrB7JCveo0332EPkH K/EhERdJI6W1uAekjiVpwplD3RHSXI0FSgafz9nx4DK7oWZvPWGQaFSpBQpTM/cs+Af+ Q6OCPb9NqJr7IoRYnUIfcyo+8ASY8+Xo6+5wSP8lhXFjUsGLw4bGOQ6zUu5mFz4pZRXg sGmb2HAG9cqu2BTxQ3ehxCT+CsiAx08OA7AtBBsRjdJWKexiLd8f2w03FvUsH7M8Z4cn vovA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=9FsdC53cWwFdjmccAWSaLCmYwhQ7YaNUY5RuBbcKHVA=; b=A3FKGa5EbebVv8N/OdvSy55GFB0XPnjLfUTqPQKpK3bj4Y90UKVmoF6vbcgNOd7RvJ lZW+Lm8yZ4HlvwKKwQWJ8wXJ+fMEk+FaYm4RPdDLclXUVZ7Ndfl4hHY+jSghqtn36ezd 1wJiNNtuk5UqH2tiVmUFb8woOuEN5hUPLCFPfM3ZwY/C3nBlV9OcwYEQYxVloQVKMmS6 Czym21UVPKKKoAZVVjkPxazFLMLBEs/8o6/C12n5coozQfkteFegtqv0H4RsZ2dCDqSj tY37NcVKbgvIjGx0FYKK7DIGx8pNZwZN1d/n1pFctNarBV1MPTfyTdG7aYuSwi1Q+Hhi L2aQ== X-Gm-Message-State: AJaThX7nYA4usLHqUbZg79s7pSodOCDSN5XLPfsHYA33+EmxLMuiXvNY N8YJ1AyysiQ7H9e8OavArrODIcBMDcyR6kv1a1suYw== X-Google-Smtp-Source: AGs4zMZWtW9JaIoxHx/I0ewyeG2IHIIT6M04ZMksWefZLzV0h7tM2CctQR3sUHDfJ+D4kYyKqUpDVycRkhc+AMBz2ZI= X-Received: by 10.36.58.3 with SMTP id m3mr212929itm.81.1510790731992; Wed, 15 Nov 2017 16:05:31 -0800 (PST) MIME-Version: 1.0 Sender: carpeddiem@gmail.com Received: by 10.107.14.208 with HTTP; Wed, 15 Nov 2017 16:05:11 -0800 (PST) In-Reply-To: <201711151847.vAFIlGD9052509@pdx.rh.CN85.dnsmgr.net> References: <201711151840.vAFIefKV002185@repo.freebsd.org> <201711151847.vAFIlGD9052509@pdx.rh.CN85.dnsmgr.net> From: Ed Maste Date: Wed, 15 Nov 2017 19:05:11 -0500 X-Google-Sender-Auth: ZYmY2KvxLJqHDEJpeutSJoLSMrw Message-ID: Subject: Re: svn commit: r325860 - head/sbin/newfs To: rgrimes@freebsd.org Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2017 00:05:33 -0000 On 15 November 2017 at 13:47, Rodney W. Grimes wrote: >> Author: emaste >> Date: Wed Nov 15 18:40:40 2017 >> New Revision: 325860 >> URL: https://svnweb.freebsd.org/changeset/base/325860 >> >> Log: >> newfs: warn if newer than kernel >> >> Creating a UFS filesystem with a newfs newer than the running kernel, >> and then mounting that filesystem, can lead to interesting failures. >> >> Add a safety belt to explicitly warn when newfs is newer than the >> running kernel. > > You should probably make the warning if (newer || older) as > either is likely to have interesting side effects, as are > mounting ufs file systems on different versions. Why would an older newfs cause trouble? Forward compatibility should be fine.