From owner-cvs-all@FreeBSD.ORG Tue Sep 5 16:57:51 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7D07016A4DF; Tue, 5 Sep 2006 16:57:51 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 29D0C43D5F; Tue, 5 Sep 2006 16:57:43 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id k85GvdVe068693; Tue, 5 Sep 2006 12:57:40 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Slawa Olhovchenkov Date: Tue, 5 Sep 2006 12:25:35 -0400 User-Agent: KMail/1.9.1 References: <200601030917.k039H4pC060911@repoman.freebsd.org> <20060903184227.GA6453%slw@zxy.spb.ru> In-Reply-To: <20060903184227.GA6453%slw@zxy.spb.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200609051225.36053.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Tue, 05 Sep 2006 12:57:40 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/1806/Tue Sep 5 11:00:48 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Brian Somers , cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.bin/su su.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Sep 2006 16:57:51 -0000 On Sunday 03 September 2006 14:42, Slawa Olhovchenkov wrote: > On Tue, Jan 03, 2006 at 09:17:04AM +0000, Brian Somers wrote: > > > brian 2006-01-03 09:17:04 UTC > > > > FreeBSD src repository > > > > Modified files: > > usr.bin/su su.c > > Log: > > Fix the other su bug reintroduced two commits ago, namely > > > > $ su > > % kill -STOP $$ > > > > where su is executing (t)csh. csh's job handling is a little more > > special than that of (a)sh, bash and even zsh and blows up a little > > more spectacularly. This modification restores the original mucking > > about with the tty pgrp, but is careful to only do it when su (or > > su's child) is the foreground process. > > > > While I'm here, fix a STDERR_FILENO spelling as suggested by bde. > > This is break 'make config' in ports tree: > > > make config > ===> Switching to root credentials to create /var/db/ports/glib20 > ===> Returning to user credentials > > Suspended (tty output) I've noticed weirdness where the tty seems to get into a funk where every su goes into suspended mode, such that I have to 'fg' and then enter the root password. Then it will keep chugging along until the next su. This seems to imply that the tty state is hosed somehow. -- John Baldwin