Date: Wed, 23 Jan 2008 20:06:20 -0800 From: Elliot <elliot.schlegelmilch@gmail.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/119937: Fwd: fix for multimedia/handbrake in amd64 Message-ID: <e5078d040801232006q1bf45ab0u51c9b48440335242@mail.gmail.com> Resent-Message-ID: <200801240440.m0O4e15M099723@freefall.freebsd.org> In-Reply-To: <200801232215.m0NMFWER042711@radon.periodic> References: <200801232215.m0NMFWER042711@radon.periodic>
next in thread | previous in thread | raw e-mail | index | archive | help
>Number: 119937
>Category: ports
>Synopsis: fix for multimedia/handbrake in amd64
>Confidential: no
>Severity: serious
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Thu Jan 24 04:40:00 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator: Elliot Sschlegelmilch
>Release: FreeBSD 7.0-PRERELEASE amd64
>Organization:
>Environment:
System: FreeBSD radon.periodic 7.0-PRERELEASE FreeBSD 7.0-PRERELEASE #0: Wed
Jan 9 23:15:42 PST 2008
elliot@phatty.r00t-servers.net:/usr/obj/usr/src/sys/PHATTY
amd64
>Description:
Handbrake on my amd64 system did not build. I suggest adding the -j
option to jam, so if the build fails, it breaks in a more expected
manner.
>How-To-Repeat:
cd /usr/ports/multimedia/handbrake; make
>Fix:
--- handbrake/files/patch-contrib-Jamfile 2007-12-13 08:50:
15.000000000 -0800
+++ handbrakeworks/files/patch-contrib-Jamfile 2008-01-23 13:32:
14.000000000 -0800
@@ -22,11 +22,11 @@
- cd `dirname $(>)` && CONTRIB=`pwd` &&
- rm -rf a52dec && tar xzf a52dec.tar.gz && cd a52dec && patch -p1 <
../patch-a52dec.patch &&
- ./configure --prefix=$CONTRIB --cache-file=$CONTRIB/config.cache &&
make && make install &&
+ CONTRIB=%%CONTRIB%% &&
+ cd $CONTRIB/a52dec && patch -p1 < ../patch-a52dec.patch &&
-+ ./configure --prefix=$CONTRIB && $(MAKE) && $(MAKE) install &&
++ ./configure --enable-shared --prefix=$CONTRIB && $(MAKE) && $(MAKE)
install &&
strip -S $CONTRIB/lib/liba52.a
}
Wget $(SUBDIR)/a52dec.tar.gz : $(SUBDIR)/version_a52dec.txt ;
@@ -58,14 +58,13 @@
}
--- handbrake/Makefile 2008-01-17 15:30:59.000000000 -0800
+++ handbrakeworks/Makefile 2008-01-23 13:31:42.000000000 -0800
@@ -57,17 +57,18 @@
${WRKSRC}/contrib/libvorbis/configure
WRKSRC= ${WRKDIR}/HandBrake
PLIST_FILES= bin/handbrake
-JAM?= ${LOCALBASE}/bin/jam
+JAM?= ${LOCALBASE}/bin/jam -j
APPLY?= /usr/bin/apply
.include <bsd.port.pre.mk>
.if ${ARCH} == "amd64"
-BROKEN= Does not compile
+#BROKEN= Does not compile
+CFLAGS+=-fPIC
.endif
# nasm/yasm needed by x264
.if ${ARCH}=="i386"
BUILD_DEPENDS+= nasm:${PORTSDIR}/devel/nasm
------=_Part_23718_24596335.1201147580772
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
<div class="gmail_quote">>Submitter-Id: current-users<br>>Originator: Elliot Sschlegelmilch<br>>Organization:<br>>Confidential: no<br>>Synopsis: fix for multimedia/handbrake in amd64<br>>Severity:
<br>>Priority: low<br>>Category: ports<br>>Class: sw-bug<br>>Release: FreeBSD 7.0-PRERELEASE amd64<br>>Environment:<br>System: FreeBSD radon.periodic 7.0-PRERELEASE FreeBSD 7.0-PRERELEASE
#0: Wed Jan 9 23:15:42 PST 2008 elliot@phatty.r00t-servers.net:/usr/obj/usr/src/sys/PHATTY amd64<br><br>>Description:<br>Handbrake on my amd64 system did not build. I suggest adding the -j<br>option to jam, so if the build fails, it breaks in a more expected
<br>manner.<br><br>>How-To-Repeat:<br>cd /usr/ports/multimedia/handbrake; make<br><br>>Fix:<br><br><br><br>--- handbrake/files/patch-contrib-Jamfile 2007-12-13 08:50:15.000000000 -0800<br>+++ handbrakeworks/files/patch-contrib-Jamfile 2008-01-23 13:32:
14.000000000 -0800<br>@@ -22,11 +22,11 @@<br> - cd `dirname $(>)` && CONTRIB=`pwd` &&<br> - rm -rf a52dec && tar xzf a52dec.tar.gz && cd a52dec && patch -p1 < ../patch-a52dec.patch
&&<br> - ./configure --prefix=$CONTRIB --cache-file=$CONTRIB/config.cache && make && make install &&<br> + CONTRIB=%%CONTRIB%% &&<br> + cd $CONTRIB/a52dec && patch -p1 < ../patch-
a52dec.patch &&<br>-+ ./configure --prefix=$CONTRIB && $(MAKE) && $(MAKE) install &&<br>++ ./configure --enable-shared --prefix=$CONTRIB && $(MAKE) && $(MAKE) install &&
<br> strip -S $CONTRIB/lib/liba52.a<br> }<br> Wget $(SUBDIR)/a52dec.tar.gz : $(SUBDIR)/version_a52dec.txt ;<br> @@ -58,14 +58,13 @@<br> }<br>--- handbrake/Makefile 2008-01-17 15:30:59.000000000 -0800<br>+++ handbrakeworks/Makefile 2008-01-23 13:31:
42.000000000 -0800<br>@@ -57,17 +57,18 @@<br> ${WRKSRC}/contrib/libvorbis/configure<br><br> WRKSRC= ${WRKDIR}/HandBrake<br> PLIST_FILES= bin/handbrake<br><br>-JAM?= ${LOCALBASE}/bin/jam
<br>+JAM?= ${LOCALBASE}/bin/jam -j<br> APPLY?= /usr/bin/apply<br><br> .include <<a href="http://bsd.port.pre.mk" target="_blank">bsd.port.pre.mk</a>><br><br> .if ${ARCH} == "amd64"<br>
-BROKEN= Does not compile<br>+#BROKEN= Does not compile<br>+CFLAGS+=-fPIC<br> .endif<br><br> # nasm/yasm needed by x264<br> .if ${ARCH}=="i386"<br> BUILD_DEPENDS+= nasm:${PORTSDIR}/devel/nasm
<br><br><br><br></div><br>
------=_Part_23718_24596335.1201147580772--
>Release-Note:
>Audit-Trail:
>Unformatted:
------=_Part_23718_24596335.1201147580772
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?e5078d040801232006q1bf45ab0u51c9b48440335242>