From owner-svn-ports-head@FreeBSD.ORG  Wed Jul 24 17:08:26 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id D3E4D7F9; Wed, 24 Jul 2013 17:08:26 +0000 (UTC)
Date: Wed, 24 Jul 2013 17:08:26 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Gabor Kovesdan <gabor@FreeBSD.org>
Subject: Re: svn commit: r323538 - in head/x11-fonts: . andika andika/files
Message-ID: <20130724170826.GA10662@FreeBSD.org>
References: <201307231610.r6NGAAwC070825@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201307231610.r6NGAAwC070825@svn.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Jul 2013 17:08:26 -0000

On Tue, Jul 23, 2013 at 04:10:10PM +0000, Gabor Kovesdan wrote:
> New Revision: 323538
> URL: http://svnweb.freebsd.org/changeset/ports/323538
> 
> @@ -0,0 +1,50 @@
> +# $FreeBSD$
> +
> +PORTNAME=	Andika

Any reason for uppercase-starting PORTNAME (and thus PKGNAME)?

> +do-configure:
> +	${DO_NADA}

If port does not use any of two *_CONFIGURE knobs, this probably is not
needed; and even if it is, it should be spelled as @${DO_NADA}.

> +do-install:
> +	${ECHO_MSG}
> +	${CAT} ${PKGMESSAGE}
> +	${ECHO_MSG}

We usually display pkg-message as the last step (after all other functional
commands).

> +	${MKDIR} ${FONTROOTDIR}/${FONTDIR}
> +	${INSTALL_DATA} ${WRKSRC}/*.ttf ${FONTROOTDIR}/${FONTDIR}
> +.if ${PORT_OPTIONS:MDOCS}
> +	${MKDIR} ${DOCSDIR}
> +	${INSTALL_DATA} ${DOCSLIST:S,^,${WRKSRC}/,} ${DOCSDIR}
> +.endif

./danfe