Date: Thu, 14 Jun 2018 10:25:52 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Joseph Mingrone <jrm@FreeBSD.org> Cc: Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-branches@freebsd.org Subject: Re: svn commit: r472343 - branches/2018Q2/devel/git-review Message-ID: <20180614082552.qowbwkx7pmeunigf@atuin.in.mat.cc> In-Reply-To: <86muvye5i3.fsf@phe.ftfl.ca> References: <201806132058.w5DKwCRe066134@repo.freebsd.org> <20180613212906.avfyauyozjkue3lz@atuin.in.mat.cc> <86muvye5i3.fsf@phe.ftfl.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
--4t35lqw34n4mxson Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 13, 2018 at 06:33:24PM -0300, Joseph Mingrone wrote: > Mathieu Arnold <mat@FreeBSD.org> writes: >=20 > > On Wed, Jun 13, 2018 at 08:58:12PM +0000, Joseph Mingrone wrote: > >> Author: jrm > >> Date: Wed Jun 13 20:58:12 2018 > >> New Revision: 472343 > >> URL: https://svnweb.freebsd.org/changeset/ports/472343 >=20 > >> Log: > >> MFH: r472342 >=20 > >> devel/git-review/Makefile: Update to version 1.26.0 >=20 > >> PR: 226100 > >> Submitted by: w.schwarzenfeld@utanet.at > >> Reported by: erj > >> Approved by: dereckson@gmail.com (maintainer) >=20 > >> Approved by: portmgr (implicit) >=20 > > I just went back to read [1], and looking at the patch, and the commit > > message, I highly doubt any of the items in the blanket approval list > > match. >=20 > > 1: https://www.freebsd.org/doc/en/articles/committers-guide/ports.html#= ports-qa-blanket >=20 > Did you read > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D226100#c0? >=20 > That sounds like "Build, runtime or packaging fixes, if the quarterly > branch version is currently broken." to me. >=20 > I probably should have noted that in the commit message. Well, no, I did not go have a look at the PR, never will, a commit message should stand by itself, especially if you are claiming some special privileges along with it. --=20 Mathieu Arnold --4t35lqw34n4mxson Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAlsiJo9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkh26xAAnJ6DIdD4CX6KVEcmxZhc+gtScHyu303SiJbnRyjhw9wI3kzvuoYcVkwi M9BtjyxRsfVtEWsYjLuddPPewjdzjHxiXQ956WftPM2jhvUmuBKjSvEOyXEiwVyx bQSK+ujFbF6x4/o5XCU1gMNR2DN2ifDuQ+qVp+Y7DrWAwQeZm51pYp0OcCKN3DOg 8ytM+5NWZF9xfv9HWqKKGY0mMbX+0/xo0DFNGGcohDEcNZS9Yn/pS1gR8OZCtmOn DhM/tEWLyKl9UZg7dYzFjmyQxfz1j6qgD8mMnewovwVYLczTFIwICEQqUdIPPE/Q yJzTmQHSU8aDvNNUDtg5qqgG1tQsWbmJaIISPy51I6T1hy+xvtVXe36axrQKYUuQ utdyDt8WpS4T/94dJwirpn1trcZLvNaOHXJIWrJaQArlCoEc4dmPfp+lYNIPky6Z 2EW58A8BAdIuRSmB30kRE476abu6YMfHN4pfiJLU3xyASLyKncytKe/I+axIKVAN cPOssIrCQ0+Kw+U3L7+xF+ht1fEo66ALn0xm4zeOf5+0NwCkxAFI5Gz2reckbyYx 8Ig5kpz8tJblwUSCYOuVgV4A9/jeUvIhbBygrZ8xYDxm3LoZKosSMOwdkn/tub8q BB4duonywLq8IDLqQCtA+tShZnyPqcgdJ4+kcP+htT43isZ5Vm4= =5pGx -----END PGP SIGNATURE----- --4t35lqw34n4mxson--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180614082552.qowbwkx7pmeunigf>