From nobody Fri May 23 13:06:59 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4b3lmg40Fdz5xD9p; Fri, 23 May 2025 13:06:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4b3lmg1N2Nz48ld; Fri, 23 May 2025 13:06:59 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1748005619; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Um5cdMCERLdTjN0m+jcDjx087vdtTglCVStatOk3Hbg=; b=BAIhnnQ0zJ7mjpnLmUbbbfAFVb6YQl5hDzwFfl6ID7sC6rxkfN6swczvghzXUd7VJB9aF2 P1S+69ew3dedYpzyUIBNyco7Xpj7SZrAExeHlDpg2/jiiBdGIeEqsXiFmuzaEolz9JYHl4 2/9xTkVU1vLltG/r+dp0TnZ+YYuZZYv3CJgNKKvtPX6S3hZUHVpfu3s0QZ8rrwYQZ6Iw+9 uFSfzf5YrKO5QRFCkL6cg+GBBEK/Yrtb3D3F08IoT9fZB7zTCWQl9Kvj4zw2BbUw2GisNz 6BoTtDdoXx678/6XF997RMk6WfucDJivUz2j2mKn4fR2YMffovskrY8k4Pi3Ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1748005619; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Um5cdMCERLdTjN0m+jcDjx087vdtTglCVStatOk3Hbg=; b=EHVM5O/TVQfCgVl6bMwq62dE+IPbP9LANZgC8eaUiiS+X6UC0ATyBrS04XiK1nhlWqv1mr 6r8XM/WCA358KHx/aUKHfH3a3u3KXUfJLOrqDezxQls/HWsK158X7yVL1U3g41YiN56nST XClQc1uQc5JiunVyFY/8S5cTxqAdevO/OFeKt03Z3m6bLyESdR8MD8FMLjth0qcazrGcur 3FDsdjw/eYskes9ZirAFvsa2UducYpamChqYtRkUnkbF+4752Wyy6p5wjnOk4LOObYzyKf IRKc7WCYkSh8r9sw+f3IXCwts+/Uye/svI/M5WOdbN0GvFRHsP9uXivRQHLEWA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1748005619; a=rsa-sha256; cv=none; b=IYIYiCaknmOH+2xSUUsYvi3fNlqSO7+uEaadCD/+f2tgRZwFl2yRg0uRvpOXno7iFSPxXJ tD+nllUwYQNLBspfccg+0TmXJ0gm9caVZ9ofjbClQ3JuHncTTX66SmbioJfpF38jvN+POW x/uUj92/B8W5kM0t1oNo7gb/L/EY0Dl1IMF6U6zGdWDbuBhtaxPGZE0rHJ6uhcFaeBmeZE FD4mgrcQvQGORKNJ9hBJKdFSSnnfUeFWAtzcLm9MjEpPk74jLjsMT7CFJ7Rdvh94Sy7cQ8 DWU9bEyd/w4Dx0lWtY1vTi/KVToiOxr77t2icMVnTiSwyCKVBh03QsN8v6C9Hg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4b3lmg0yzWz16YZ; Fri, 23 May 2025 13:06:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 54ND6x7J045738; Fri, 23 May 2025 13:06:59 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 54ND6xFU045735; Fri, 23 May 2025 13:06:59 GMT (envelope-from git) Date: Fri, 23 May 2025 13:06:59 GMT Message-Id: <202505231306.54ND6xFU045735@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kristof Provost Subject: git: 0a16f62701f1 - main - icmp6: zero out pad space List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 0a16f62701f163f85449ad6c6dcf742b5247e8d2 Auto-Submitted: auto-generated The branch main has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=0a16f62701f163f85449ad6c6dcf742b5247e8d2 commit 0a16f62701f163f85449ad6c6dcf742b5247e8d2 Author: Kristof Provost AuthorDate: 2025-05-22 09:23:59 +0000 Commit: Kristof Provost CommitDate: 2025-05-23 13:06:33 +0000 icmp6: zero out pad space In icmp6_redirect_output() we potentially add padding, but failed to clear this memory. This triggered a KMSAN panic during the sys/netinet/carp:unicast_v6 test. Reviewed by: zlei Sponsored by: Rubicon Communications, LLC ("Netgate") Differential Revision: https://reviews.freebsd.org/D50461 --- sys/netinet6/icmp6.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/netinet6/icmp6.c b/sys/netinet6/icmp6.c index 764e57ef9b76..eaf8514fd5cf 100644 --- a/sys/netinet6/icmp6.c +++ b/sys/netinet6/icmp6.c @@ -2605,6 +2605,7 @@ nolladdropt: /* pad if easy enough, truncate if not */ if (8 - extra <= M_TRAILINGSPACE(m0)) { /* pad */ + bzero(m0->m_data + m0->m_len, 8 - extra); m0->m_len += (8 - extra); m0->m_pkthdr.len += (8 - extra); } else {