From owner-cvs-all Sun Mar 10 14:18:11 2002 Delivered-To: cvs-all@freebsd.org Received: from alcatraz.iptelecom.net.ua (alcatraz.iptelecom.net.ua [212.9.224.15]) by hub.freebsd.org (Postfix) with ESMTP id B87C137B402; Sun, 10 Mar 2002 14:18:02 -0800 (PST) Received: from ipcard.iptcom.net (ipcard.iptcom.net [212.9.224.5]) by alcatraz.iptelecom.net.ua (8.9.3/8.9.3) with ESMTP id AAA22543; Mon, 11 Mar 2002 00:18:00 +0200 (EET) (envelope-from sobomax@FreeBSD.org) Received: from h160.228.dialup.iptcom.net (h160.228.dialup.iptcom.net [212.9.228.160]) by ipcard.iptcom.net (8.9.3/8.9.3) with ESMTP id AAA24000; Mon, 11 Mar 2002 00:17:57 +0200 (EET) (envelope-from sobomax@FreeBSD.org) Subject: Re: cvs commit: src/sys/kern kern_linker.c From: Maxim Sobolev To: David Malone Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org In-Reply-To: <20020310202940.GA94559@walton.maths.tcd.ie> References: <200203101920.g2AJK1B38135@freefall.freebsd.org> <20020310202940.GA94559@walton.maths.tcd.ie> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-BG+9gR96JkQpWFK+Yizt" Message-Id: <1015798536.527.38.camel@notebook> Mime-Version: 1.0 X-Mailer: Evolution/1.0.2 Date: 11 Mar 2002 00:17:27 +0200 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --=-BG+9gR96JkQpWFK+Yizt Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Sun, 2002-03-10 at 22:29, David Malone wrote: > On Sun, Mar 10, 2002 at 11:20:01AM -0800, Maxim Sobolev wrote: > > sobomax 2002/03/10 11:20:01 PST > >=20 > > Modified files: > > sys/kern kern_linker.c=20 > > Log: > > Fix a breakage introduced in rev.1.75 (supposedly style cleanup), whi= ch results > > in "missing dependencies" error when loading some kld modules. It is = sad to > > see how often these days style cleanus break doesn't broken things. P= erhaps > > people should recall good old principle: "don't fix it if it isn't br= oken". >=20 > Maxim, >=20 > Would you mind if I chaned all the "err =3D strcmp() if (err =3D=3D 0)"s > in this file into "if (strcmp() =3D=3D 0)". The fix I proposed in the > PR mentioned by Steven did this (it fixed the same bug and made the > strcmps a little more sane). Yeah, please do. -Maxim --=-BG+9gR96JkQpWFK+Yizt Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (FreeBSD) Comment: For info see http://www.gnupg.org iD8DBQA8i9sIoNu5t4iCBa8RApdOAJ0QPeuRt/4qAOUz2ZZsggkyakMu0gCfac9m F69I9lRpnH+yGsThW0ktMe8= =79cW -----END PGP SIGNATURE----- --=-BG+9gR96JkQpWFK+Yizt-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message