From owner-freebsd-bugs@FreeBSD.ORG Fri Aug 20 13:16:53 2010 Return-Path: Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0863E106566C; Fri, 20 Aug 2010 13:16:53 +0000 (UTC) (envelope-from jhellenthal@gmail.com) Received: from mail-qw0-f54.google.com (mail-qw0-f54.google.com [209.85.216.54]) by mx1.freebsd.org (Postfix) with ESMTP id 8F6208FC12; Fri, 20 Aug 2010 13:16:52 +0000 (UTC) Received: by qwg5 with SMTP id 5so3301732qwg.13 for ; Fri, 20 Aug 2010 06:16:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :x-enigmail-version:content-type:content-transfer-encoding; bh=nck3v2oBYNw7IkTT+rdsED8QDj/2O9O7Kefh4/xkwX0=; b=tG6ewELrP3APNu/Ap3fPWcpKRdb0mOBC7Y6rLng6zQ4qeT/JBbjhMwKgqxoiuM4vVx kjIM9aPqbG9lPl8TQsLaa2ZBqOM0h0X+WQzbNLaEla6Kyq/6hlp3ZIML9go00NWK0RKV r8hWHkzWHEgr8oW+sNfj93hTP1A2LzbjMmhpY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=rJfFml1eFeozxe/fS5w5JSyfVFt7SAQUinF86r5i96k1dFsUBUDjbknXm6QUH4HSLx J7We1c6GliagT4t8vRMVHZiJIOxrtFoZOvvRaFg5UGNtyLYU+HSlOo8d28vqZ4b3ZKHl WO6qJxdRlnJHb95tRG5fVhuNhz1g/Nd7VDqJU= Received: by 10.224.6.145 with SMTP id 17mr945024qaz.140.1282310211478; Fri, 20 Aug 2010 06:16:51 -0700 (PDT) Received: from centel.dataix.local (adsl-99-190-84-182.dsl.klmzmi.sbcglobal.net [99.190.84.182]) by mx.google.com with ESMTPS id l13sm2979707qck.7.2010.08.20.06.16.49 (version=SSLv3 cipher=RC4-MD5); Fri, 20 Aug 2010 06:16:50 -0700 (PDT) Sender: "J. Hellenthal" Message-ID: <4C6E803F.9030602@DataIX.net> Date: Fri, 20 Aug 2010 09:16:47 -0400 From: jhell User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.2.8) Gecko/20100806 Lightning/1.0b1 Thunderbird MIME-Version: 1.0 To: walter@pelissero.de References: <4C6C7518.7010906@DataIX.net> <19565.8946.444567.257102@zaphod.home.lan> <4C6D5D6F.5060907@DataIX.net> <19566.20916.868818.924898@zaphod.home.lan> In-Reply-To: <19566.20916.868818.924898@zaphod.home.lan> X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-bugs@freebsd.org, bug-followup@freebsd.org Subject: Re: kern/149762: volume labels with rogue characters X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Aug 2010 13:16:53 -0000 On 08/20/2010 05:58, Walter C. Pelissero wrote: > jhell writes: > > Putting aside whats written below, please don't feel that this is an > > attack on your work to make this happen. > > Attack on my work? > Amusing. > > > > I feel your work is very viable for what it is supposed to do but > > to the same effect does not address the issue that this might > > happen elsewhere to anything new that may be introduced to the > > system at a later point in time > > What don't you understand in: > Now kern.geom.label.sanitation can be set to zero (default) > obtaining the usual behaviour without "hack". I understand that completely still it is not a proper fix for the situation. > > > > In a previous post I mentioned a proper full term solution based on > > adjusting devfs/devd instead that would fit future situations and > > not call for individual adjustments for pieces of geom or anything > > related. > > I failed to see the devfs/devd solution you mention. I believe I meant patch devfs/devd here rather than adjust. Since were dealing with what shows up in the device file-system why not patch that instead of horrifying pieces of the system, one at a time. vfs.devfs.``normalization'' - Would probably suit this. I don't expect you to understand this... ;) > > > > It has be ~6 years that GEOM_LABEL was introduced to the system. > > r131476 | pjd | 2004-07-02 15:40:36 -0400 (Fri, 02 Jul 2004) | 22 lines > > conf/37569 > Mon Apr 29 08:40:01 PDT 2002 > > The common issue of all the already mentioned PRs is: mounting volumes > with names that are not compatible with fstab (and a lot of other > things). Which this modification of geom_label could mitigate. > > There is a related PR of mine, which tackles the problem from the > fstab stand point, that does more or less what the other PR has been > already suggesting since 2002 and Linux has been doing for more than a > decade. > > It was closed by a sulky baby boy on the same grounds as this. > Personally I have seen enough of the hash and bash coming from anyone here. Ive tried to make sure that what I have wrote back as a reply to your work was neither demeaning or intrusive but yet you continue to take the same negative standpoint with objection toward further ideas all the while holding an immature context with a submitter. Besides this! It is not really needed to adjust your personal system for the likes of some labels that may contain weird characters that conflict with how the system parses fstab(5). Simply by using the 'link' action in devfs.conf(5) you can create a link to a device auto-magically when the device is plugged in that would be available for use in fstab(5). link label/my?edgecase myedgecase2 link msdosfs/your?edgecase myedgecase3 This is only performed if the device appears. In fstab(5) /dev/myedgecase2 /headcase2 msdosfs rw,noauto 0 0 /dev/myedgecase3 /headcase3 msdosfs rw,noauto 0 0 Of course you can also adjust devd.conf(5) for example to perform specific actions upon device entry but Ill let you figure that out. Regards, -- jhell,v