From owner-freebsd-ports@FreeBSD.ORG  Mon Mar 20 15:50:57 2006
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
X-Original-To: ports@freebsd.org
Delivered-To: freebsd-ports@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 248F516A42C;
	Mon, 20 Mar 2006 15:50:57 +0000 (UTC)
	(envelope-from brdavis@odin.ac.hmc.edu)
Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D31CA43D5E;
	Mon, 20 Mar 2006 15:50:51 +0000 (GMT)
	(envelope-from brdavis@odin.ac.hmc.edu)
Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1])
	by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id k2KFoo6H018921;
	Mon, 20 Mar 2006 07:50:50 -0800
Received: (from brdavis@localhost)
	by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id k2KFooQr018920;
	Mon, 20 Mar 2006 07:50:50 -0800
Date: Mon, 20 Mar 2006 07:50:50 -0800
From: Brooks Davis <brooks@one-eyed-alien.net>
To: Doug Barton <dougb@freebsd.org>
Message-ID: <20060320155050.GA18306@odin.ac.hmc.edu>
References: <C0435540.ADB4%ceri@submonkey.net> <441E657C.1040209@FreeBSD.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="k1lZvvs/B4yU6o8G"
Content-Disposition: inline
In-Reply-To: <441E657C.1040209@FreeBSD.org>
User-Agent: Mutt/1.4.1i
X-Virus-Scanned: by amavisd-new
X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63
X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu
Cc: ports@freebsd.org, Ceri Davies <ceri@submonkey.net>, doc@freebsd.org,
	Alfred Morgan <alfred.morgan@experclick.com>
Subject: Re: update document
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Mar 2006 15:50:57 -0000


--k1lZvvs/B4yU6o8G
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 20, 2006 at 12:19:08AM -0800, Doug Barton wrote:
> Ceri Davies wrote:
> > On 15/3/06 19:15, "Alfred Morgan" <alfred.morgan@experclick.com> wrote:
> >=20
> >> In this document:
> >> http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-s=
cripts.h
> >> tml
> >>
> >> Can we change:
> >>
> >> rcvar=3D${name}_enable
> >>
> >> to be :
> >>
> >> rcvar=3D`set_rcvar`
> >>
> >> so that it would be a good example how to be other OS (OpenBSD)
> >> compatible as well.
>=20
> The set_rcvar function simply returns ${name}_enable, so setting that val=
ue
> explicitly in the example removes a layer of indirection, and helps make =
it
> more clear what's happening there, which makes it a better example.

I disagree unless we're planning to deprecate set_rcvar.  Either we
should always use it in new scripts (and thus in examples) or get rid of
it.

-- Brooks

--=20
Any statement of the form "X is the one, true Y" is FALSE.
PGP fingerprint 655D 519C 26A7 82E7 2529  9BF0 5D8E 8BE9 F238 1AD4

--k1lZvvs/B4yU6o8G
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQFEHs9ZXY6L6fI4GtQRAjCoAJ9gdO2k1k0NKYJGsPfN44AHxy8/CgCg5Pse
5IqAOO3VZeq7Y4vz7tvXWUA=
=q3PD
-----END PGP SIGNATURE-----

--k1lZvvs/B4yU6o8G--